From: Jason Gunthorpe <jgg@nvidia.com>
To: Lukas Wunner <lukas@wunner.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ard Biesheuvel <ardb@kernel.org>,
linux-kernel@vger.kernel.org, patches@lists.linux.dev,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Subject: Re: [PATCH] sysfs: Add stub sysfs_bin_attr_simple_read() for !CONFIG_SYSFS
Date: Mon, 3 Jun 2024 19:15:07 -0300 [thread overview]
Message-ID: <20240603221507.GC19897@nvidia.com> (raw)
In-Reply-To: <Zl4rqswlbGM-eRY6@wunner.de>
On Mon, Jun 03, 2024 at 10:46:34PM +0200, Lukas Wunner wrote:
> On Mon, Jun 03, 2024 at 02:30:45PM -0300, Jason Gunthorpe wrote:
> > Since the only declaration for sysfs_bin_attr_simple_read() is inside the
> > "#ifdef CONFIG_SYSFS". Add a stub to the #else section too.
> [...]
> > I don't see a patch for this yet, but I did find a 0-day robot complaint:
> >
> > https://lore.kernel.org/all/202404200345.eGdn5uxW-lkp@intel.com/
>
> I already submitted a patch on May 23, but it hasn't been applied yet:
>
> https://lore.kernel.org/all/05f4290439a58730738a15b0c99cd8576c4aa0d9.1716461752.git.lukas@wunner.de/
Ah, it is not a good practice to put patches you want applied buried
in a thread, that is perhaps why it has been overlooked..
> (My patch returns 0, yours -EINVAL, but I don't think that matters.)
Yes, it looks like the function will never be called.
Jason
prev parent reply other threads:[~2024-06-03 22:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 17:30 [PATCH] sysfs: Add stub sysfs_bin_attr_simple_read() for !CONFIG_SYSFS Jason Gunthorpe
2024-06-03 20:46 ` Lukas Wunner
2024-06-03 22:15 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240603221507.GC19897@nvidia.com \
--to=jgg@nvidia.com \
--cc=ardb@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=patches@lists.linux.dev \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox