Re: [PATCH v2 11/22] ath10k: Use iommu_paging_domain_alloc()

Jeff Johnson
2024-06-04T13:40:15Z

+ath10k list for viibility

On 6/3/24 18:51, Lu Baolu wrote:
> An iommu domain is allocated in ath10k_fw_init() and is attached to
> ar_snoc->fw.dev in the same function. Use iommu_paging_domain_alloc() to
> make it explicit.
>
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> ---
> drivers/net/wireless/ath/ath10k/snoc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/snoc.c b/drivers/net/wireless/ath/ath10k/snoc.c
> index 8530550cf5df..0fe47d51013c 100644
> --- a/drivers/net/wireless/ath/ath10k/snoc.c
> +++ b/drivers/net/wireless/ath/ath10k/snoc.c
> @@ -1635,10 +1635,10 @@ static int ath10k_fw_init(struct ath10k *ar)
>
> ar_snoc->fw.dev = &pdev->dev;
>
> - iommu_dom = iommu_domain_alloc(&platform_bus_type);
> - if (!iommu_dom) {
> + iommu_dom = iommu_paging_domain_alloc(ar_snoc->fw.dev);
> + if (IS_ERR(iommu_dom)) {
> ath10k_err(ar, "failed to allocate iommu domain\n");
> - ret = -ENOMEM;
> + ret = PTR_ERR(iommu_dom);
> goto err_unregister;
> }
>