public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lu Baolu <baolu.lu@linux.intel.com>
To: Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>,
	Jason Gunthorpe <jgg@ziepe.ca>, Kevin Tian <kevin.tian@intel.com>
Cc: Yi Liu <yi.l.liu@intel.com>, David Airlie <airlied@gmail.com>,
	Daniel Vetter <daniel@ffwll.ch>, Kalle Valo <kvalo@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	mst@redhat.com, Jason Wang <jasowang@redhat.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Mikko Perttunen <mperttunen@nvidia.com>,
	iommu@lists.linux.dev, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, Lu Baolu <baolu.lu@linux.intel.com>
Subject: [PATCH v2 01/22] iommu: Add iommu_user_domain_alloc() interface
Date: Tue,  4 Jun 2024 09:51:13 +0800	[thread overview]
Message-ID: <20240604015134.164206-2-baolu.lu@linux.intel.com> (raw)
In-Reply-To: <20240604015134.164206-1-baolu.lu@linux.intel.com>

Commit <909f4abd1097> ("iommu: Add new iommu op to create domains owned
by userspace") added a dedicated iommu op to allocate a user domain.
While IOMMUFD has already made use of this callback, other frameworks
like vfio/type1 and vDPA still use the paging domain allocation interface.

Add a new interface named iommu_user_domain_alloc(), which indicates the
allocation of a domain for device DMA managed by user space driver. All
device passthrough frameworks could use this interface for their domain
allocation.

Although it is expected that all iommu drivers could implement their own
domain_alloc_user ops, most drivers haven't implemented it yet. Rollback
to the paging domain allocation interface if the iommu driver hasn't
implemented this op yet.

Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
---
 include/linux/iommu.h |  6 ++++++
 drivers/iommu/iommu.c | 42 ++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 48 insertions(+)

diff --git a/include/linux/iommu.h b/include/linux/iommu.h
index 7bc8dff7cf6d..6648b2415474 100644
--- a/include/linux/iommu.h
+++ b/include/linux/iommu.h
@@ -780,6 +780,7 @@ extern bool iommu_present(const struct bus_type *bus);
 extern bool device_iommu_capable(struct device *dev, enum iommu_cap cap);
 extern bool iommu_group_has_isolated_msi(struct iommu_group *group);
 extern struct iommu_domain *iommu_domain_alloc(const struct bus_type *bus);
+struct iommu_domain *iommu_user_domain_alloc(struct device *dev, u32 flags);
 extern void iommu_domain_free(struct iommu_domain *domain);
 extern int iommu_attach_device(struct iommu_domain *domain,
 			       struct device *dev);
@@ -1086,6 +1087,11 @@ static inline struct iommu_domain *iommu_domain_alloc(const struct bus_type *bus
 	return NULL;
 }
 
+static inline struct iommu_domain *iommu_user_domain_alloc(struct device *dev, u32 flags)
+{
+	return ERR_PTR(-ENODEV);
+}
+
 static inline void iommu_domain_free(struct iommu_domain *domain)
 {
 }
diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index 9df7cc75c1bc..f1416892ef8e 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -2032,6 +2032,48 @@ struct iommu_domain *iommu_domain_alloc(const struct bus_type *bus)
 }
 EXPORT_SYMBOL_GPL(iommu_domain_alloc);
 
+/**
+ * iommu_user_domain_alloc() - Allocate a user domain
+ * @dev: device for which the domain is allocated
+ * @flags: iommufd_hwpt_alloc_flags defined in uapi/linux/iommufd.h
+ *
+ * Allocate a user domain which will be managed by a userspace driver. Return
+ * allocated domain if successful, or a ERR pointer for failure.
+ */
+struct iommu_domain *iommu_user_domain_alloc(struct device *dev, u32 flags)
+{
+	struct iommu_domain *domain;
+	const struct iommu_ops *ops;
+
+	if (!dev_has_iommu(dev))
+		return ERR_PTR(-ENODEV);
+
+	ops = dev_iommu_ops(dev);
+	if (ops->domain_alloc_user) {
+		domain = ops->domain_alloc_user(dev, flags, NULL, NULL);
+		if (IS_ERR(domain))
+			return domain;
+
+		domain->type = IOMMU_DOMAIN_UNMANAGED;
+		domain->owner = ops;
+		domain->pgsize_bitmap = ops->pgsize_bitmap;
+		domain->ops = ops->default_domain_ops;
+
+		return domain;
+	}
+
+	/*
+	 * The iommu driver doesn't support domain_alloc_user callback.
+	 * Rollback to a UNMANAGED paging domain which doesn't support
+	 * the allocation flags.
+	 */
+	if (flags)
+		return ERR_PTR(-EOPNOTSUPP);
+
+	return __iommu_domain_alloc(ops, dev, IOMMU_DOMAIN_UNMANAGED);
+}
+EXPORT_SYMBOL_GPL(iommu_user_domain_alloc);
+
 void iommu_domain_free(struct iommu_domain *domain)
 {
 	if (domain->type == IOMMU_DOMAIN_SVA)
-- 
2.34.1


  reply	other threads:[~2024-06-04  1:53 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-04  1:51 [PATCH v2 00/22] iommu: Refactoring domain allocation interface Lu Baolu
2024-06-04  1:51 ` Lu Baolu [this message]
2024-06-04  8:03   ` [PATCH v2 01/22] iommu: Add iommu_user_domain_alloc() interface Yi Liu
2024-06-05  2:00     ` Baolu Lu
2024-06-05  6:23       ` Yi Liu
2024-06-06  2:04         ` Baolu Lu
2024-06-04  1:51 ` [PATCH v2 02/22] iommufd: Use iommu_user_domain_alloc() Lu Baolu
2024-06-04 16:51   ` Jason Gunthorpe
2024-06-05  2:17     ` Baolu Lu
2024-06-05 12:02       ` Jason Gunthorpe
2024-06-04  1:51 ` [PATCH v2 03/22] vfio/type1: " Lu Baolu
2024-06-04  1:51 ` [PATCH v2 04/22] vhost-vdpa: " Lu Baolu
2024-06-04  1:51 ` [PATCH v2 05/22] iommu: Add iommu_paging_domain_alloc() interface Lu Baolu
2024-06-04  1:51 ` [PATCH v2 06/22] drm/msm: Use iommu_paging_domain_alloc() Lu Baolu
2024-06-04  7:48   ` Dmitry Baryshkov
2024-06-04  1:51 ` [PATCH v2 07/22] drm/nouveau/tegra: " Lu Baolu
2024-06-04  1:51 ` [PATCH v2 08/22] gpu: host1x: " Lu Baolu
2024-06-04  1:51 ` [PATCH v2 09/22] media: nvidia: tegra: " Lu Baolu
2024-06-04  1:51 ` [PATCH v2 10/22] media: venus: firmware: " Lu Baolu
2024-06-04  1:51 ` [PATCH v2 11/22] ath10k: " Lu Baolu
2024-06-04 13:35   ` Jeff Johnson
2024-06-04 13:39   ` Jeff Johnson
2024-06-04  1:51 ` [PATCH v2 12/22] wifi: ath11k: " Lu Baolu
2024-06-04  8:19   ` Kalle Valo
2024-06-04 13:34   ` Jeff Johnson
2024-06-04  1:51 ` [PATCH v2 13/22] remoteproc: " Lu Baolu
2024-06-04  1:51 ` [PATCH v2 14/22] soc/fsl/qbman: " Lu Baolu
2024-06-04  1:51 ` [PATCH v2 15/22] RDMA/usnic: " Lu Baolu
2024-06-04 16:44   ` Jason Gunthorpe
2024-06-04  1:51 ` [PATCH v2 16/22] iommu/vt-d: Add helper to allocate paging domain Lu Baolu
2024-06-04  1:51 ` [PATCH v2 17/22] ARM: dma-mapping: Pass device to arm_iommu_create_mapping() Lu Baolu
2024-06-04  1:51 ` [PATCH v2 18/22] ARM: dma-mapping: Use iommu_paging_domain_alloc() Lu Baolu
2024-06-04  1:51 ` [PATCH v2 19/22] drm/rockchip: " Lu Baolu
2024-06-04  1:51 ` [PATCH v2 20/22] drm/tegra: Remove call to iommu_domain_alloc() Lu Baolu
2024-06-04  1:51 ` [PATCH v2 21/22] iommu: Remove iommu_present() Lu Baolu
2024-06-04  1:51 ` [PATCH v2 22/22] iommu: Remove iommu_domain_alloc() Lu Baolu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240604015134.164206-2-baolu.lu@linux.intel.com \
    --to=baolu.lu@linux.intel.com \
    --cc=airlied@gmail.com \
    --cc=alex.williamson@redhat.com \
    --cc=andersson@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=iommu@lists.linux.dev \
    --cc=jasowang@redhat.com \
    --cc=jgg@ziepe.ca \
    --cc=jonathanh@nvidia.com \
    --cc=joro@8bytes.org \
    --cc=kevin.tian@intel.com \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=mperttunen@nvidia.com \
    --cc=mst@redhat.com \
    --cc=robin.murphy@arm.com \
    --cc=thierry.reding@gmail.com \
    --cc=will@kernel.org \
    --cc=yi.l.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox