Re: [PATCH 01/10] mm/ksm: reduce the flush action for ksm merging page

David Hildenbrand
2024-06-04T08:07:39Z

On 04.06.24 06:24, alexs@kernel.org wrote:
> From: "Alex Shi (tencent)" <alexs@kernel.org>
>
> We can put off the flush action util a merging is realy coming. That
> could reduce some unmerge page flushing.
> BTW, flushing only do at arm, mips and few other archs.
>

I'm no expert on that flushing, but I thought we would have to do the
flushing before accessing page content -- before calculating the
checksum etc.

Now you would only do it before the pages_identical() check, but not
when calculating the checksum.

--
Cheers,

David / dhildenb