public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan+linaro@kernel.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Bard Liao <yung-chuan.liao@linux.intel.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Sanyog Kale <sanyog.r.kale@intel.com>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	Johan Hovold <johan+linaro@kernel.org>
Subject: [PATCH v2 1/4] soundwire: bus: suppress probe deferral errors
Date: Tue,  4 Jun 2024 09:52:10 +0200	[thread overview]
Message-ID: <20240604075213.20815-2-johan+linaro@kernel.org> (raw)
In-Reply-To: <20240604075213.20815-1-johan+linaro@kernel.org>

Soundwire driver probe errors are currently being logged both by the bus
code and driver core:

	wsa884x-codec sdw:4:0:0217:0204:00:0: Probe of wsa884x-codec failed: -12
	wsa884x-codec sdw:4:0:0217:0204:00:0: probe with driver wsa884x-codec failed with error -12

Drop the redundant bus error message, which is also incorrectly being
logged on probe deferral:

	wsa884x-codec sdw:4:0:0217:0204:00:0: Probe of wsa884x-codec failed: -517

Note that no soundwire driver uses the driver struct name field, which
will be removed by a follow-on change.

Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 drivers/soundwire/bus_type.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/soundwire/bus_type.c b/drivers/soundwire/bus_type.c
index c32faace618f..85fa5970d98a 100644
--- a/drivers/soundwire/bus_type.c
+++ b/drivers/soundwire/bus_type.c
@@ -83,7 +83,6 @@ static int sdw_drv_probe(struct device *dev)
 	struct sdw_slave *slave = dev_to_sdw_dev(dev);
 	struct sdw_driver *drv = drv_to_sdw_driver(dev->driver);
 	const struct sdw_device_id *id;
-	const char *name;
 	int ret;
 
 	/*
@@ -108,11 +107,6 @@ static int sdw_drv_probe(struct device *dev)
 
 	ret = drv->probe(slave, id);
 	if (ret) {
-		name = drv->name;
-		if (!name)
-			name = drv->driver.name;
-
-		dev_err(dev, "Probe of %s failed: %d\n", name, ret);
 		dev_pm_domain_detach(dev, false);
 		return ret;
 	}
-- 
2.44.1


  reply	other threads:[~2024-06-04  7:52 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-04  7:52 [PATCH v2 0/4] soundwire: bus: suppress probe deferral errors Johan Hovold
2024-06-04  7:52 ` Johan Hovold [this message]
2024-06-04  8:30   ` [PATCH v2 1/4] " Pierre-Louis Bossart
2024-06-04  9:09     ` Johan Hovold
2024-06-04 13:29       ` Pierre-Louis Bossart
2024-06-04  7:52 ` [PATCH v2 2/4] soundwire: bus: drop unused driver name field Johan Hovold
2024-06-04  7:52 ` [PATCH v2 3/4] soundwire: bus: clean up probe warnings Johan Hovold
2024-06-04  8:33   ` Pierre-Louis Bossart
2024-06-04  9:17     ` Johan Hovold
2024-06-04 13:43       ` Pierre-Louis Bossart
2024-06-04 14:18         ` Johan Hovold
2024-06-04 15:07           ` Pierre-Louis Bossart
2024-06-05 12:11             ` Johan Hovold
2024-06-05 16:15               ` Pierre-Louis Bossart
2024-06-04  7:52 ` [PATCH v2 4/4] soundwire: bus: drop redundant probe debug message Johan Hovold
2024-06-04  8:37   ` Pierre-Louis Bossart
2024-06-04  9:24     ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240604075213.20815-2-johan+linaro@kernel.org \
    --to=johan+linaro@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=sanyog.r.kale@intel.com \
    --cc=vkoul@kernel.org \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox