The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: James Clark <james.clark@arm.com>
To: coresight@lists.linaro.org, suzuki.poulose@arm.com,
	gankulkarni@os.amperecomputing.com, mike.leach@linaro.org,
	leo.yan@linux.dev, anshuman.khandual@arm.com
Cc: James Clark <james.clark@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>, Jiri Olsa <jolsa@kernel.org>,
	Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	John Garry <john.g.garry@oracle.com>,
	Will Deacon <will@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-perf-users@vger.kernel.org
Subject: [PATCH v2 02/16] perf auxtrace: Allow number of queues to be specified
Date: Tue,  4 Jun 2024 15:30:11 +0100	[thread overview]
Message-ID: <20240604143030.519906-3-james.clark@arm.com> (raw)
In-Reply-To: <20240604143030.519906-1-james.clark@arm.com>

Currently it's only possible to initialize with the default number of
queues and then use auxtrace_queues__add_event() to grow the array. But
that's problematic if you don't have a real event to pass into that
function yet.

The queues hold a void *priv member to store custom state, and for
Coresight we want to create decoders upfront before receiving data, so
add a new function that allows pre-allocating queues. One reason to do
this is because we might need to store metadata (HW_ID events) that
effects other queues, but never actually receive auxtrace data on that
queue.

Signed-off-by: James Clark <james.clark@arm.com>
---
 tools/perf/util/auxtrace.c | 9 +++++++--
 tools/perf/util/auxtrace.h | 1 +
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/tools/perf/util/auxtrace.c b/tools/perf/util/auxtrace.c
index 3684e6009b63..563b6c4fca31 100644
--- a/tools/perf/util/auxtrace.c
+++ b/tools/perf/util/auxtrace.c
@@ -218,15 +218,20 @@ static struct auxtrace_queue *auxtrace_alloc_queue_array(unsigned int nr_queues)
 	return queue_array;
 }
 
-int auxtrace_queues__init(struct auxtrace_queues *queues)
+int auxtrace_queues__init_nr(struct auxtrace_queues *queues, int nr_queues)
 {
-	queues->nr_queues = AUXTRACE_INIT_NR_QUEUES;
+	queues->nr_queues = nr_queues;
 	queues->queue_array = auxtrace_alloc_queue_array(queues->nr_queues);
 	if (!queues->queue_array)
 		return -ENOMEM;
 	return 0;
 }
 
+int auxtrace_queues__init(struct auxtrace_queues *queues)
+{
+	return auxtrace_queues__init_nr(queues, AUXTRACE_INIT_NR_QUEUES);
+}
+
 static int auxtrace_queues__grow(struct auxtrace_queues *queues,
 				 unsigned int new_nr_queues)
 {
diff --git a/tools/perf/util/auxtrace.h b/tools/perf/util/auxtrace.h
index 55702215a82d..8a6ec9565835 100644
--- a/tools/perf/util/auxtrace.h
+++ b/tools/perf/util/auxtrace.h
@@ -521,6 +521,7 @@ int auxtrace_mmap__read_snapshot(struct mmap *map,
 				 struct perf_tool *tool, process_auxtrace_t fn,
 				 size_t snapshot_size);
 
+int auxtrace_queues__init_nr(struct auxtrace_queues *queues, int nr_queues);
 int auxtrace_queues__init(struct auxtrace_queues *queues);
 int auxtrace_queues__add_event(struct auxtrace_queues *queues,
 			       struct perf_session *session,
-- 
2.34.1


  parent reply	other threads:[~2024-06-04 14:31 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-04 14:30 [PATCH v2 00/16] coresight: Use per-sink trace ID maps for Perf sessions James Clark
2024-06-04 14:30 ` [PATCH v2 01/16] perf cs-etm: Print error for new PERF_RECORD_AUX_OUTPUT_HW_ID versions James Clark
2024-06-04 14:30 ` James Clark [this message]
2024-06-05  5:26   ` [PATCH v2 02/16] perf auxtrace: Allow number of queues to be specified Adrian Hunter
2024-06-05  8:19     ` James Clark
2024-06-04 14:30 ` [PATCH v2 03/16] perf: cs-etm: Create decoders after both AUX and HW_ID search passes James Clark
2024-06-04 14:30 ` [PATCH v2 04/16] perf: cs-etm: Allocate queues for all CPUs James Clark
2024-06-04 14:30 ` [PATCH v2 05/16] perf: cs-etm: Move traceid_list to each queue James Clark
2024-06-04 14:30 ` [PATCH v2 06/16] perf: cs-etm: Create decoders based on the trace ID mappings James Clark
2024-06-04 14:30 ` [PATCH v2 07/16] perf: cs-etm: Support version 0.1 of HW_ID packets James Clark
2024-06-04 14:30 ` [PATCH v2 08/16] coresight: Remove unused ETM Perf stubs James Clark
2024-06-04 14:30 ` [PATCH v2 09/16] coresight: Clarify comments around the PID of the sink owner James Clark
2024-06-04 14:30 ` [PATCH v2 10/16] coresight: Move struct coresight_trace_id_map to common header James Clark
2024-06-04 14:30 ` [PATCH v2 11/16] coresight: Expose map arguments in trace ID API James Clark
2024-06-06 13:50   ` Suzuki K Poulose
2024-06-06 14:10     ` James Clark
2024-06-04 14:30 ` [PATCH v2 12/16] coresight: Make CPU id map a property of a trace ID map James Clark
2024-06-04 14:30 ` [PATCH v2 13/16] coresight: Use per-sink trace ID maps for Perf sessions James Clark
2024-06-07 13:18   ` Suzuki K Poulose
2024-06-07 13:40     ` James Clark
2024-06-04 14:30 ` [PATCH v2 14/16] coresight: Remove pending trace ID release mechanism James Clark
2024-06-07 13:43   ` Suzuki K Poulose
2024-06-10 15:27     ` James Clark
2024-06-04 14:30 ` [PATCH v2 15/16] coresight: Re-emit trace IDs when the sink changes in per-thread mode James Clark
2024-06-10 10:29   ` Suzuki K Poulose
2024-06-10 14:05     ` James Clark
2024-06-04 14:30 ` [PATCH v2 16/16] coresight: Emit sink ID in the HW_ID packets James Clark
2024-06-05 20:35 ` [PATCH v2 00/16] coresight: Use per-sink trace ID maps for Perf sessions Leo Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240604143030.519906-3-james.clark@arm.com \
    --to=james.clark@arm.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=anshuman.khandual@arm.com \
    --cc=coresight@lists.linaro.org \
    --cc=gankulkarni@os.amperecomputing.com \
    --cc=irogers@google.com \
    --cc=john.g.garry@oracle.com \
    --cc=jolsa@kernel.org \
    --cc=leo.yan@linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mark.rutland@arm.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=mike.leach@linaro.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=suzuki.poulose@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox