From: "Paul E. McKenney" <paulmck@kernel.org>
To: rcu@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com,
rostedt@goodmis.org, Frederic Weisbecker <frederic@kernel.org>,
"Paul E . McKenney" <paulmck@kernel.org>
Subject: [PATCH rcu 4/6] rcu: Remove full memory barrier on boot time eqs sanity check
Date: Tue, 4 Jun 2024 15:26:50 -0700 [thread overview]
Message-ID: <20240604222652.2370998-4-paulmck@kernel.org> (raw)
In-Reply-To: <81f4e616-8125-4934-a8e2-fd5beae90995@paulmck-laptop>
From: Frederic Weisbecker <frederic@kernel.org>
When the boot CPU initializes the per-CPU data on behalf of all possible
CPUs, a sanity check is performed on each of them to make sure none is
initialized in an extended quiescent state.
This check involves a full memory barrier which is useless at this early
boot stage.
Do a plain access instead.
Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
---
kernel/rcu/tree.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index 1a6ef9c5c949e..9fa6d2b557d6c 100644
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@@ -4772,7 +4772,7 @@ rcu_boot_init_percpu_data(int cpu)
rdp->grpmask = leaf_node_cpu_bit(rdp->mynode, cpu);
INIT_WORK(&rdp->strict_work, strict_work_handler);
WARN_ON_ONCE(ct->dynticks_nesting != 1);
- WARN_ON_ONCE(rcu_dynticks_in_eqs(rcu_dynticks_snap(cpu)));
+ WARN_ON_ONCE(rcu_dynticks_in_eqs(ct_dynticks_cpu(cpu)));
rdp->barrier_seq_snap = rcu_state.barrier_sequence;
rdp->rcu_ofl_gp_seq = rcu_state.gp_seq;
rdp->rcu_ofl_gp_state = RCU_GP_CLEANED;
--
2.40.1
next prev parent reply other threads:[~2024-06-04 22:26 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 22:26 [PATCH rcu 0/6] Grace-period memory-barrier adjustments for v6.11 Paul E. McKenney
2024-06-04 22:26 ` [PATCH rcu 1/6] rcu: Remove full ordering on second EQS snapshot Paul E. McKenney
2024-06-05 12:21 ` Frederic Weisbecker
2024-06-05 18:44 ` Paul E. McKenney
2024-06-26 15:03 ` Frederic Weisbecker
2024-06-26 15:32 ` Paul E. McKenney
2024-06-26 15:44 ` Frederic Weisbecker
2024-06-27 11:27 ` [PATCH rcu 1/6 v2] " Frederic Weisbecker
2024-06-04 22:26 ` [PATCH rcu 2/6] rcu: Remove superfluous full memory barrier upon first " Paul E. McKenney
2024-06-12 8:27 ` Neeraj upadhyay
2024-06-26 14:13 ` Frederic Weisbecker
2024-06-26 17:19 ` Neeraj upadhyay
2024-06-26 22:03 ` Frederic Weisbecker
2024-06-27 2:16 ` Neeraj upadhyay
2024-06-27 2:40 ` Neeraj upadhyay
2024-06-27 11:11 ` Frederic Weisbecker
2024-06-27 11:32 ` [PATCH rcu 2/6 v2] " Frederic Weisbecker
2024-06-04 22:26 ` [PATCH rcu 3/6] rcu/exp: " Paul E. McKenney
2024-06-12 8:44 ` Neeraj upadhyay
2024-06-12 14:45 ` Paul E. McKenney
2024-06-26 14:28 ` Frederic Weisbecker
2024-06-26 17:19 ` Neeraj upadhyay
2024-06-26 22:12 ` Frederic Weisbecker
2024-06-27 2:33 ` Neeraj upadhyay
2024-06-27 11:36 ` [PATCH rcu 3/6 v2] " Frederic Weisbecker
2024-06-27 18:53 ` Paul E. McKenney
2024-06-28 11:20 ` Frederic Weisbecker
2024-06-28 20:03 ` Paul E. McKenney
2024-06-04 22:26 ` Paul E. McKenney [this message]
2024-06-04 22:26 ` [PATCH rcu 5/6] rcu: Remove full memory barrier on RCU stall printout Paul E. McKenney
2024-06-04 22:26 ` [PATCH rcu 6/6] rcu/exp: Remove redundant full memory barrier at the end of GP Paul E. McKenney
2024-06-12 5:21 ` [PATCH rcu 0/6] Grace-period memory-barrier adjustments for v6.11 Boqun Feng
2024-06-12 9:42 ` Neeraj Upadhyay
2024-06-12 14:46 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240604222652.2370998-4-paulmck@kernel.org \
--to=paulmck@kernel.org \
--cc=frederic@kernel.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox