From: Steven Rostedt <rostedt@goodmis.org>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
Mark Rutland <mark.rutland@arm.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 3/5] ftrace: Remove "filter_hash" parameter from ftrace_hash_rec_disable/enable()
Date: Wed, 5 Jun 2024 17:54:28 -0400 [thread overview]
Message-ID: <20240605175428.1a07acbe@rorschach.local.home> (raw)
In-Reply-To: <20240606065018.0bf1d82a3bf9c526aee9a170@kernel.org>
On Thu, 6 Jun 2024 06:50:18 +0900
Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:
> On Tue, 04 Jun 2024 17:28:20 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
>
> > From: "Steven Rostedt (Google)" <rostedt@goodmis.org>
> >
> > The functions ftrace_hash_rec_disable() and ftrace_hash_rec_enable()
> > always has 1 passed to its "ftrace_hash" parameter. Remove the parameter
> > and pass in true to __ftrace_hash_rec_update().
> >
> > Also add some comments to both those functions explaining what they do.
> >
>
> Looks good to me.
>
> Reviewed-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Thanks Masami, but I sent out a v2. Could you review those patches
instead?
https://lore.kernel.org/all/20240605180334.090848865@goodmis.org/
-- Steve
next prev parent reply other threads:[~2024-06-05 21:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 21:28 [PATCH 0/5] ftrace: Clean up and comment code Steven Rostedt
2024-06-04 21:28 ` [PATCH 1/5] ftrace: Rename dup_hash() and comment it Steven Rostedt
2024-06-05 21:46 ` Masami Hiramatsu
2024-06-04 21:28 ` [PATCH 2/5] ftrace: Comment __ftrace_hash_rec_update() and make filter_hash bool Steven Rostedt
2024-06-05 10:15 ` Mark Rutland
2024-06-05 14:18 ` Steven Rostedt
2024-06-05 16:06 ` Steven Rostedt
2024-06-04 21:28 ` [PATCH 3/5] ftrace: Remove "filter_hash" parameter from ftrace_hash_rec_disable/enable() Steven Rostedt
2024-06-05 10:17 ` Mark Rutland
2024-06-05 18:05 ` Steven Rostedt
2024-06-05 21:50 ` Masami Hiramatsu
2024-06-05 21:54 ` Steven Rostedt [this message]
2024-06-04 21:28 ` [PATCH 4/5] ftrace: Convert "filter_hash" and "inc" to bool in ftrace_hash_rec_update_modify() Steven Rostedt
2024-06-05 1:12 ` kernel test robot
2024-06-05 1:57 ` Steven Rostedt
2024-06-05 5:15 ` kernel test robot
2024-06-05 10:22 ` Mark Rutland
2024-06-04 21:28 ` [PATCH 5/5] ftrace: Add comments to ftrace_hash_move() and friends Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240605175428.1a07acbe@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox