Re: [PATCH 1/2] platform/chrome: cros_ec_proto: Upgrade get_next_event to v3

Tzung-Bi Shih
2024-06-04T03:12:36Z

On Mon, Jun 03, 2024 at 05:53:12PM -0700, Daisuke Nojiri wrote:
> This CL upgrades get_next_event to version 3.

s/This CL upgrades/Upgrade/.

> BUG=b:331761304
> TEST=Type keys on Kyogre.

Please remove the tags as upstream doesn't use them.

> .../linux/platform_data/cros_ec_commands.h | 34 +++++++++++++++++++

Please separate the changes of the header into an independent patch. Says,
the changes in the header is a "sync" from include/ec_commands.h of EC which
is unlikely to be reverted. However, the rest of changes in the patch could
be reverted if something went wrong.