[RFC PATCH 1/4] regulator: core: Ensure the cached state matches the hardware state in regulator_set_voltage_unlocked()

Prabhakar
2024-06-05T07:49:48Z

From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Ensure that the cached state matches the hardware setting before
considering it a no-op in regulator_set_voltage_unlocked().

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
Driver code flow:
1> set regulator to 1.8V (BIT0 = 1)
2> Regulator cached state now will be 1.8V
3> Now for some reason driver issues a reset to the IP block
which resets the registers to default value. In this process
the regulator is set to 3.3V (BIT0 = 0)
4> Now the driver requests the regulator core to set 1.8V
5> Due to below check of cached state we return back with success
resulting undesired behaviour.

Hence an additional check is introduced to make sure the cache state
is matching with the HW.
---
drivers/regulator/core.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 5794f4e9dd52..65ee54b13428 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -3765,10 +3765,13 @@ static int regulator_set_voltage_unlocked(struct regulator *regulator,

/* If we're setting the same range as last time the change
* should be a noop (some cpufreq implementations use the same
- * voltage for multiple frequencies, for example).
+ * voltage for multiple frequencies, for example). Also make sure
+ * state is the same in HW.
*/
- if (voltage->min_uV == min_uV && voltage->max_uV == max_uV)
- goto out;
+ if (voltage->min_uV == min_uV && voltage->max_uV == max_uV) {
+ if (regulator_get_voltage_rdev(rdev) == min_uV)
+ goto out;
+ }

/* If we're trying to set a range that overlaps the current voltage,
* return successfully even though the regulator does not support
--
2.34.1