Re: [RFC PATCH 2/4] regulator: core: Add regulator_map_voltage_descend() API

Geert Uytterhoeven
2024-06-20T14:52:26Z

Hi Prabhakar,

On Wed, Jun 5, 2024 at 9:49 AM Prabhakar <prabhakar.csengg@gmail.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Similarly to regulator_map_voltage_ascend() api add
> regulator_map_voltage_descend() api and export it.
>
> Drivers that have descendant voltage list can use this as their
> map_voltage() operation.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Thanks for your patch!

> --- a/drivers/regulator/helpers.c
> +++ b/drivers/regulator/helpers.c
> @@ -368,6 +368,37 @@ int regulator_map_voltage_ascend(struct regulator_dev *rdev,
> }
> EXPORT_SYMBOL_GPL(regulator_map_voltage_ascend);
>
> +/**
> + * regulator_map_voltage_descend - map_voltage() for descendant voltage list
> + *
> + * @rdev: Regulator to operate on
> + * @min_uV: Lower bound for voltage
> + * @max_uV: Upper bound for voltage
> + *
> + * Drivers that have descendant voltage list can use this as their
> + * map_voltage() operation.
> + */
> +int regulator_map_voltage_descend(struct regulator_dev *rdev,
> + int min_uV, int max_uV)
> +{
> + int i, ret;
> +
> + for (i = rdev->desc->n_voltages - 1; i >= 0 ; i--) {
> + ret = rdev->desc->ops->list_voltage(rdev, i);
> + if (ret < 0)
> + continue;
> +
> + if (ret > min_uV)

I know this patch is superseded, but shouldn't this be "<"?

> + break;
> +
> + if (ret >= min_uV && ret <= max_uV)
> + return i;
> + }
> +
> + return -EINVAL;
> +}
> +EXPORT_SYMBOL_GPL(regulator_map_voltage_descend);
> +
> /**
> * regulator_map_voltage_linear - map_voltage() for simple linear mappings
> *

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds