From: Rob Herring <robh@kernel.org>
To: Animesh Agarwal <animeshagarwal28@gmail.com>,
Neil Armstrong <neil.armstrong@linaro.org>
Cc: Daniel Baluta <daniel.baluta@nxp.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: dt-bindings: linux,spdif-dir: Convert to dtschema
Date: Wed, 5 Jun 2024 18:53:32 -0600 [thread overview]
Message-ID: <20240606005332.GA3526959-robh@kernel.org> (raw)
In-Reply-To: <20240605112301.8171-1-animeshagarwal28@gmail.com>
On Wed, Jun 05, 2024 at 04:52:55PM +0530, Animesh Agarwal wrote:
> Convert the dummy SPDIF receiver bindings to DT schema. Make bindings
> complete by adding property "#sound-dai-cells"
2 conversions of the same thing in one day:
https://lore.kernel.org/all/20240605-topic-amlogic-upstream-bindings-convert-spdif-receiver-v1-1-262465adbac2@linaro.org/
As I said there, I would just add the compatible to
linux,spdif-dit.yaml. But this is fine too.
>
> Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
> Cc: Daniel Baluta <daniel.baluta@nxp.com>
> ---
> .../bindings/sound/linux,spdif-dir.yaml | 34 +++++++++++++++++++
> .../bindings/sound/spdif-receiver.txt | 10 ------
> 2 files changed, 34 insertions(+), 10 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/sound/linux,spdif-dir.yaml
> delete mode 100644 Documentation/devicetree/bindings/sound/spdif-receiver.txt
>
> diff --git a/Documentation/devicetree/bindings/sound/linux,spdif-dir.yaml b/Documentation/devicetree/bindings/sound/linux,spdif-dir.yaml
> new file mode 100644
> index 000000000000..61767873200f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/linux,spdif-dir.yaml
> @@ -0,0 +1,34 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/linux,spdif-dir.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Dummy SPDIF receiver
> +
> +maintainers:
> + - Liam Girdwood <lgirdwood@gmail.com>
> + - Mark Brown <broonie@kernel.org>
> +
> +allOf:
> + - $ref: dai-common.yaml#
> +
> +properties:
> + compatible:
> + const: linux,spdif-dir
> +
> + "#sound-dai-cells":
> + const: 0
It wasn't in the txt binding, but users also use 'sound-name-prefix'
property, so that should be added here.
Rob
next prev parent reply other threads:[~2024-06-06 0:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 11:22 [PATCH] ASoC: dt-bindings: linux,spdif-dir: Convert to dtschema Animesh Agarwal
2024-06-06 0:53 ` Rob Herring [this message]
2024-06-06 2:19 ` Animesh Agarwal
2024-06-06 7:57 ` Neil Armstrong
2024-06-07 5:59 ` Animesh Agarwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240606005332.GA3526959-robh@kernel.org \
--to=robh@kernel.org \
--cc=animeshagarwal28@gmail.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox