Re: [PATCH] ASoC: dt-bindings: linux,spdif-dir: Convert to dtschema

Animesh Agarwal
2024-06-06T02:19:39Z

On Thu, Jun 6, 2024 at 6:23 AM Rob Herring <robh@kernel.org> wrote:
>
> On Wed, Jun 05, 2024 at 04:52:55PM +0530, Animesh Agarwal wrote:
> > Convert the dummy SPDIF receiver bindings to DT schema. Make bindings
> > complete by adding property "#sound-dai-cells"
>
> 2 conversions of the same thing in one day:
>
> https://lore.kernel.org/all/20240605-topic-amlogic-upstream-bindings-convert-spdif-receiver-v1-1-262465adbac2@linaro.org/
>
> As I said there, I would just add the compatible to
> linux,spdif-dit.yaml. But this is fine too.
>
> >
> > Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
> > Cc: Daniel Baluta <daniel.baluta@nxp.com>
> > ---
> > .../bindings/sound/linux,spdif-dir.yaml | 34 +++++++++++++++++++
> > .../bindings/sound/spdif-receiver.txt | 10 ------
> > 2 files changed, 34 insertions(+), 10 deletions(-)
> > create mode 100644 Documentation/devicetree/bindings/sound/linux,spdif-dir.yaml
> > delete mode 100644 Documentation/devicetree/bindings/sound/spdif-receiver.txt
> >
> > diff --git a/Documentation/devicetree/bindings/sound/linux,spdif-dir.yaml b/Documentation/devicetree/bindings/sound/linux,spdif-dir.yaml
> > new file mode 100644
> > index 000000000000..61767873200f
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/linux,spdif-dir.yaml
> > @@ -0,0 +1,34 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/sound/linux,spdif-dir.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Dummy SPDIF receiver
> > +
> > +maintainers:
> > + - Liam Girdwood <lgirdwood@gmail.com>
> > + - Mark Brown <broonie@kernel.org>
> > +
> > +allOf:
> > + - $ref: dai-common.yaml#
> > +
> > +properties:
> > + compatible:
> > + const: linux,spdif-dir
> > +
> > + "#sound-dai-cells":
> > + const: 0
>
> It wasn't in the txt binding, but users also use 'sound-name-prefix'
> property, so that should be added here.
linux,spdif-dir.yaml

If this is the case, I'll add the linux,spdif-dir compatible in
linux,spdif-dit.yaml instead of creating a new file in v2 of this
patch.

Regards,
Animesh Agarwal