From: Bjorn Helgaas <helgaas@kernel.org>
To: "Dr. David Alan Gilbert" <linux@treblig.org>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
bhelgaas@google.com, rafael@kernel.org,
linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ACPI: PCI: Remove unused struct 'acpi_handle_node'
Date: Thu, 6 Jun 2024 14:55:58 -0500 [thread overview]
Message-ID: <20240606195558.GA816336@bhelgaas> (raw)
In-Reply-To: <Zk9cTVvPoyzM4hYm@gallifrey>
On Thu, May 23, 2024 at 03:10:05PM +0000, Dr. David Alan Gilbert wrote:
> * Jonathan Cameron (Jonathan.Cameron@Huawei.com) wrote:
> > On Thu, 9 May 2024 01:08:58 +0100
> > linux@treblig.org wrote:
> >
> > > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > >
> > > 'acpi_handle_node' is unused since
> > > Commit 63f534b8bad9 ("ACPI: PCI: Rework acpi_get_pci_dev()")
> > > Remove it.
> > >
> > > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> >
> > FWIW, indeed unused.
> >
> > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Thanks; any idea who would pick this up?
Applied with Jonathan's reviewed-by to pci/misc for v6.11, thanks!
Rafael, let me know if you want this instead. Easy for me to drop if
you do.
> > > ---
> > > drivers/acpi/pci_root.c | 5 -----
> > > 1 file changed, 5 deletions(-)
> > >
> > > diff --git a/drivers/acpi/pci_root.c b/drivers/acpi/pci_root.c
> > > index 58b89b8d950ed..59e6955e24edb 100644
> > > --- a/drivers/acpi/pci_root.c
> > > +++ b/drivers/acpi/pci_root.c
> > > @@ -293,11 +293,6 @@ struct acpi_pci_root *acpi_pci_find_root(acpi_handle handle)
> > > }
> > > EXPORT_SYMBOL_GPL(acpi_pci_find_root);
> > >
> > > -struct acpi_handle_node {
> > > - struct list_head node;
> > > - acpi_handle handle;
> > > -};
> > > -
> > > /**
> > > * acpi_get_pci_dev - convert ACPI CA handle to struct pci_dev
> > > * @handle: the handle in question
> >
> >
> --
> -----Open up your eyes, open up your mind, open up your code -------
> / Dr. David Alan Gilbert | Running GNU/Linux | Happy \
> \ dave @ treblig.org | | In Hex /
> \ _________________________|_____ http://www.treblig.org |_______/
prev parent reply other threads:[~2024-06-06 19:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 0:08 [PATCH] ACPI: PCI: Remove unused struct 'acpi_handle_node' linux
2024-05-09 10:57 ` Jonathan Cameron
2024-05-23 15:10 ` Dr. David Alan Gilbert
2024-06-06 19:55 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240606195558.GA816336@bhelgaas \
--to=helgaas@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=bhelgaas@google.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@treblig.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox