public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>
To: netdev@vger.kernel.org
Cc: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Edward Cree" <ecree.xilinx@gmail.com>,
	"Martin Habets" <habetsm.xilinx@gmail.com>,
	linux-net-drivers@amd.com, "Saeed Mahameed" <saeedm@nvidia.com>,
	"Leon Romanovsky" <leon@kernel.org>,
	"Tariq Toukan" <tariqt@nvidia.com>,
	linux-rdma@vger.kernel.org,
	"Jesse Brandeburg" <jesse.brandeburg@intel.com>,
	"Tony Nguyen" <anthony.l.nguyen@intel.com>,
	intel-wired-lan@lists.osuosl.org,
	"Louis Peens" <louis.peens@corigine.com>,
	oss-drivers@corigine.com, linux-kernel@vger.kernel.org,
	"Davide Caratti" <dcaratti@redhat.com>,
	i.maximets@ovn.org
Subject: [PATCH net-next 2/5] sfc: use flow_rule_is_supp_enc_control_flags()
Date: Sun,  9 Jun 2024 17:33:52 +0000	[thread overview]
Message-ID: <20240609173358.193178-3-ast@fiberby.net> (raw)
In-Reply-To: <20240609173358.193178-1-ast@fiberby.net>

Change the existing check for unsupported encapsulation control flags,
to use the new helper flow_rule_is_supp_enc_control_flags().

No functional change, only compile tested.

Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
---
 drivers/net/ethernet/sfc/tc.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/sfc/tc.c b/drivers/net/ethernet/sfc/tc.c
index 9d140203e273a..0d93164988fc6 100644
--- a/drivers/net/ethernet/sfc/tc.c
+++ b/drivers/net/ethernet/sfc/tc.c
@@ -387,11 +387,8 @@ static int efx_tc_flower_parse_match(struct efx_nic *efx,
 		struct flow_match_control fm;
 
 		flow_rule_match_enc_control(rule, &fm);
-		if (fm.mask->flags) {
-			NL_SET_ERR_MSG_FMT_MOD(extack, "Unsupported match on enc_control.flags %#x",
-					       fm.mask->flags);
+		if (flow_rule_has_enc_control_flags(fm.mask->flags, extack))
 			return -EOPNOTSUPP;
-		}
 		if (!IS_ALL_ONES(fm.mask->addr_type)) {
 			NL_SET_ERR_MSG_FMT_MOD(extack, "Unsupported enc addr_type mask %u (key %u)",
 					       fm.mask->addr_type,
-- 
2.45.1


  parent reply	other threads:[~2024-06-09 17:34 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-09 17:33 [PATCH net-next 0/5] net: flower: validate encapsulation control flags Asbjørn Sloth Tønnesen
2024-06-09 17:33 ` [PATCH net-next 1/5] flow_offload: add encapsulation control flag helpers Asbjørn Sloth Tønnesen
2024-06-09 17:33 ` Asbjørn Sloth Tønnesen [this message]
2024-06-10 19:31   ` [PATCH net-next 2/5] sfc: use flow_rule_is_supp_enc_control_flags() Edward Cree
2024-06-09 17:33 ` [PATCH net-next 3/5] net/mlx5e: flower: validate encapsulation control flags Asbjørn Sloth Tønnesen
2024-06-09 17:33 ` [PATCH net-next 4/5] nfp: " Asbjørn Sloth Tønnesen
2024-06-11  7:24   ` Louis Peens
2024-06-09 17:33 ` [PATCH net-next 5/5] ice: " Asbjørn Sloth Tønnesen
2024-06-10  9:06   ` [Intel-wired-lan] " Marcin Szycik
2024-06-11  9:09 ` [PATCH net-next 0/5] net: " Davide Caratti
2024-06-13  1:04 ` Jakub Kicinski
2024-06-13 17:38   ` Asbjørn Sloth Tønnesen
2024-06-13  1:10 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240609173358.193178-3-ast@fiberby.net \
    --to=ast@fiberby.net \
    --cc=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=dcaratti@redhat.com \
    --cc=ecree.xilinx@gmail.com \
    --cc=edumazet@google.com \
    --cc=habetsm.xilinx@gmail.com \
    --cc=i.maximets@ovn.org \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jesse.brandeburg@intel.com \
    --cc=kuba@kernel.org \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-net-drivers@amd.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=louis.peens@corigine.com \
    --cc=netdev@vger.kernel.org \
    --cc=oss-drivers@corigine.com \
    --cc=pabeni@redhat.com \
    --cc=saeedm@nvidia.com \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox