public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lu Baolu <baolu.lu@linux.intel.com>
To: Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>,
	Jason Gunthorpe <jgg@ziepe.ca>, Kevin Tian <kevin.tian@intel.com>
Cc: Yi Liu <yi.l.liu@intel.com>, David Airlie <airlied@gmail.com>,
	Daniel Vetter <daniel@ffwll.ch>, Kalle Valo <kvalo@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	mst@redhat.com, Jason Wang <jasowang@redhat.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Mikko Perttunen <mperttunen@nvidia.com>,
	Jeff Johnson <quic_jjohnson@quicinc.com>,
	ath10k@lists.infradead.org, ath11k@lists.infradead.org,
	iommu@lists.linux.dev, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, Lu Baolu <baolu.lu@linux.intel.com>
Subject: [PATCH v3 00/21] iommu: Refactoring domain allocation interface
Date: Mon, 10 Jun 2024 16:55:34 +0800	[thread overview]
Message-ID: <20240610085555.88197-1-baolu.lu@linux.intel.com> (raw)

The IOMMU subsystem has undergone some changes, including the removal
of iommu_ops from the bus structure. Consequently, the existing domain
allocation interface, which relies on a bus type argument, is no longer
relevant:

    struct iommu_domain *iommu_domain_alloc(struct bus_type *bus)

This series is designed to refactor the use of this interface. It
proposes a new interface iommu_paging_domain_alloc() to replace
iommu_domain_alloc(). This interface is for allocating iommu paging
domains for kernel drivers. It takes a device pointer as a parameter,
which better reflects the current design of the IOMMU subsystem.

The majority of device drivers currently using iommu_domain_alloc() do
so to allocate a domain for a specific device and then attach that
domain to the device. These cases can be straightforwardly migrated to
the new interface.

The drm/tegra driver is a bit different in that the device pointer
passed to the helper, which allocates the iommu domain, is not the one
that will be used for the kernel DMA API. Move the existing logic in
iommu_domain_alloc() into the driver to ensure it works as intended.

Now that all consumers of iommu_domain_alloc() have switched to the new
interface, we can finally remove iommu_domain_alloc(). This removal
paves the way for the IOMMU subsystem to support multiple iommu drivers.
Additionally, the individual iommu driver implementation for domain
allocation could also be simplified, as there will always be a valid
device pointer passed along the path.

The whole series is also available on GitHub:
https://github.com/LuBaolu/intel-iommu/commits/iommu-domain-allocation-refactor-v3

Change log:

v3:
 - Remove the proposed iommu_user_domain_alloc() interface.

v2: https://lore.kernel.org/linux-iommu/20240604015134.164206-1-baolu.lu@linux.intel.com/
 - Drop the vt-d patches which implement paging domain support from this
   series. I will post them in a separate series later.
 - Convert all drivers that call iommu_domain_alloc() to use the new
   interface and remove iommu_domain_alloc() from the tree.
 - For the drm/msm driver, make the code compatible with the no-IOMMU
   case.
 - Various cleanups and refinements.

v1: https://lore.kernel.org/linux-iommu/20240529053250.91284-1-baolu.lu@linux.intel.com/

Lu Baolu (20):
  iommu: Add iommu_paging_domain_alloc() interface
  iommufd: Use iommu_paging_domain_alloc()
  vfio/type1: Use iommu_paging_domain_alloc()
  vhost-vdpa: Use iommu_paging_domain_alloc()
  drm/msm: Use iommu_paging_domain_alloc()
  drm/nouveau/tegra: Use iommu_paging_domain_alloc()
  gpu: host1x: Use iommu_paging_domain_alloc()
  media: nvidia: tegra: Use iommu_paging_domain_alloc()
  media: venus: firmware: Use iommu_paging_domain_alloc()
  wifi: ath10k: Use iommu_paging_domain_alloc()
  wifi: ath11k: Use iommu_paging_domain_alloc()
  remoteproc: Use iommu_paging_domain_alloc()
  soc/fsl/qbman: Use iommu_paging_domain_alloc()
  RDMA/usnic: Use iommu_paging_domain_alloc()
  iommu/vt-d: Add helper to allocate paging domain
  ARM: dma-mapping: Use iommu_paging_domain_alloc()
  drm/rockchip: Use iommu_paging_domain_alloc()
  drm/tegra: Remove call to iommu_domain_alloc()
  iommu: Remove iommu_present()
  iommu: Remove iommu_domain_alloc()

Robin Murphy (1):
  ARM: dma-mapping: Pass device to arm_iommu_create_mapping()

 include/linux/iommu.h                         | 12 +--
 arch/arm/include/asm/dma-iommu.h              |  2 +-
 arch/arm/mm/dma-mapping.c                     | 12 +--
 drivers/gpu/drm/exynos/exynos_drm_dma.c       |  2 +-
 drivers/gpu/drm/msm/msm_iommu.c               |  7 +-
 .../drm/nouveau/nvkm/engine/device/tegra.c    |  4 +-
 drivers/gpu/drm/rockchip/rockchip_drm_drv.c   | 10 ++-
 drivers/gpu/drm/tegra/drm.c                   | 34 ++++++--
 drivers/gpu/host1x/dev.c                      |  7 +-
 drivers/infiniband/hw/usnic/usnic_uiom.c      |  6 +-
 drivers/iommu/intel/iommu.c                   | 87 +++++++++++++++++--
 drivers/iommu/iommu.c                         | 63 +++-----------
 drivers/iommu/iommufd/hw_pagetable.c          |  7 +-
 drivers/iommu/ipmmu-vmsa.c                    |  3 +-
 drivers/iommu/mtk_iommu_v1.c                  |  3 +-
 .../media/platform/nvidia/tegra-vde/iommu.c   |  7 +-
 drivers/media/platform/qcom/venus/firmware.c  |  6 +-
 drivers/media/platform/ti/omap3isp/isp.c      |  2 +-
 drivers/net/wireless/ath/ath10k/snoc.c        |  6 +-
 drivers/net/wireless/ath/ath11k/ahb.c         |  6 +-
 drivers/remoteproc/remoteproc_core.c          |  6 +-
 drivers/soc/fsl/qbman/qman_portal.c           |  5 +-
 drivers/vfio/vfio_iommu_type1.c               |  7 +-
 drivers/vhost/vdpa.c                          | 14 ++-
 24 files changed, 183 insertions(+), 135 deletions(-)

-- 
2.34.1


             reply	other threads:[~2024-06-10  8:58 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-10  8:55 Lu Baolu [this message]
2024-06-10  8:55 ` [PATCH v3 01/21] iommu: Add iommu_paging_domain_alloc() interface Lu Baolu
2024-06-19 14:20   ` Jason Gunthorpe
2024-06-27  7:10   ` Vasant Hegde
2024-06-10  8:55 ` [PATCH v3 02/21] iommufd: Use iommu_paging_domain_alloc() Lu Baolu
2024-06-19 14:21   ` Jason Gunthorpe
2024-06-10  8:55 ` [PATCH v3 03/21] vfio/type1: " Lu Baolu
2024-06-19 14:21   ` Jason Gunthorpe
2024-06-10  8:55 ` [PATCH v3 04/21] vhost-vdpa: " Lu Baolu
2024-06-19 14:27   ` Jason Gunthorpe
2024-07-03 16:32   ` Michael S. Tsirkin
2024-07-04 13:53     ` Will Deacon
2024-06-10  8:55 ` [PATCH v3 05/21] drm/msm: " Lu Baolu
2024-06-10  8:55 ` [PATCH v3 06/21] drm/nouveau/tegra: " Lu Baolu
2024-06-10  8:55 ` [PATCH v3 07/21] gpu: host1x: " Lu Baolu
2024-06-19 14:30   ` Jason Gunthorpe
2024-06-10  8:55 ` [PATCH v3 08/21] media: nvidia: tegra: " Lu Baolu
2024-06-19 14:31   ` Jason Gunthorpe
2024-06-10  8:55 ` [PATCH v3 09/21] media: venus: firmware: " Lu Baolu
2024-06-19 14:32   ` Jason Gunthorpe
2024-06-10  8:55 ` [PATCH v3 10/21] wifi: ath10k: " Lu Baolu
2024-06-19 14:37   ` Jason Gunthorpe
2024-06-10  8:55 ` [PATCH v3 11/21] wifi: ath11k: " Lu Baolu
2024-06-19 14:38   ` Jason Gunthorpe
2024-06-10  8:55 ` [PATCH v3 12/21] remoteproc: " Lu Baolu
2024-06-19 14:38   ` Jason Gunthorpe
2024-06-10  8:55 ` [PATCH v3 13/21] soc/fsl/qbman: " Lu Baolu
2024-06-19 14:39   ` Jason Gunthorpe
2024-06-10  8:55 ` [PATCH v3 14/21] RDMA/usnic: " Lu Baolu
2024-06-10  8:55 ` [PATCH v3 15/21] iommu/vt-d: Add helper to allocate paging domain Lu Baolu
2024-06-19 15:12   ` Jason Gunthorpe
2024-06-20  1:14     ` Baolu Lu
2024-06-28  5:42   ` Yi Liu
2024-06-28  8:29     ` Baolu Lu
2024-06-10  8:55 ` [PATCH v3 16/21] ARM: dma-mapping: Pass device to arm_iommu_create_mapping() Lu Baolu
2024-06-10  8:55 ` [PATCH v3 17/21] ARM: dma-mapping: Use iommu_paging_domain_alloc() Lu Baolu
2024-06-19 15:13   ` Jason Gunthorpe
2024-06-10  8:55 ` [PATCH v3 18/21] drm/rockchip: " Lu Baolu
2024-06-19 15:14   ` Jason Gunthorpe
2024-06-10  8:55 ` [PATCH v3 19/21] drm/tegra: Remove call to iommu_domain_alloc() Lu Baolu
2024-06-10  8:55 ` [PATCH v3 20/21] iommu: Remove iommu_present() Lu Baolu
2024-06-19 15:14   ` Jason Gunthorpe
2024-06-10  8:55 ` [PATCH v3 21/21] iommu: Remove iommu_domain_alloc() Lu Baolu
2024-06-19 15:14   ` Jason Gunthorpe
2024-06-19 14:37 ` [PATCH v3 00/21] iommu: Refactoring domain allocation interface Jason Gunthorpe
2024-07-04 14:18 ` Will Deacon
2024-07-04 14:24   ` Baolu Lu
2024-07-04 14:34     ` Will Deacon
2024-07-08 16:34   ` Jason Gunthorpe
2024-07-09  2:10     ` Baolu Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240610085555.88197-1-baolu.lu@linux.intel.com \
    --to=baolu.lu@linux.intel.com \
    --cc=airlied@gmail.com \
    --cc=alex.williamson@redhat.com \
    --cc=andersson@kernel.org \
    --cc=ath10k@lists.infradead.org \
    --cc=ath11k@lists.infradead.org \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=iommu@lists.linux.dev \
    --cc=jasowang@redhat.com \
    --cc=jgg@ziepe.ca \
    --cc=jonathanh@nvidia.com \
    --cc=joro@8bytes.org \
    --cc=kevin.tian@intel.com \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=mperttunen@nvidia.com \
    --cc=mst@redhat.com \
    --cc=quic_jjohnson@quicinc.com \
    --cc=robin.murphy@arm.com \
    --cc=thierry.reding@gmail.com \
    --cc=will@kernel.org \
    --cc=yi.l.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox