From: Tree Davies <tdavies@darkphysics.net>
To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Tree Davies <tdavies@darkphysics.net>
Subject: [PATCH v2 02/24] Staging: rtl8192e: Rename variable bIsMulticast
Date: Tue, 11 Jun 2024 20:22:08 -0700 [thread overview]
Message-ID: <20240612032230.9738-3-tdavies@darkphysics.net> (raw)
In-Reply-To: <20240612032230.9738-1-tdavies@darkphysics.net>
Rename variable bIsMulticast to is_multicast
to fix checkpatch warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
v2: No Change
drivers/staging/rtl8192e/rtllib_tx.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192e/rtllib_tx.c
index 87d1ff943617..8856191a1228 100644
--- a/drivers/staging/rtl8192e/rtllib_tx.c
+++ b/drivers/staging/rtl8192e/rtllib_tx.c
@@ -538,7 +538,7 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struct net_device *dev)
u8 src[ETH_ALEN];
struct lib80211_crypt_data *crypt = NULL;
struct cb_desc *tcb_desc;
- u8 bIsMulticast = false;
+ u8 is_multicast = false;
u8 IsAmsdu = false;
bool bdhcp = false;
@@ -655,14 +655,14 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struct net_device *dev)
ether_addr_copy(header.addr3, dest);
}
- bIsMulticast = is_multicast_ether_addr(header.addr1);
+ is_multicast = is_multicast_ether_addr(header.addr1);
header.frame_control = cpu_to_le16(fc);
/* Determine fragmentation size based on destination (multicast
* and broadcast are not fragmented)
*/
- if (bIsMulticast) {
+ if (is_multicast) {
frag_size = MAX_FRAG_THRESHOLD;
qos_ctl |= QOS_CTL_NOTCONTAIN_ACK;
} else {
@@ -774,7 +774,7 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struct net_device *dev)
/* The last fragment has the remaining length */
bytes = bytes_last_frag;
}
- if ((qos_activated) && (!bIsMulticast)) {
+ if ((qos_activated) && (!is_multicast)) {
frag_hdr->seq_ctrl =
cpu_to_le16(rtllib_query_seqnum(ieee, skb_frag,
header.addr1));
@@ -809,7 +809,7 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struct net_device *dev)
skb_put(skb_frag, 4);
}
- if ((qos_activated) && (!bIsMulticast)) {
+ if ((qos_activated) && (!is_multicast)) {
if (ieee->seq_ctrl[UP2AC(skb->priority) + 1] == 0xFFF)
ieee->seq_ctrl[UP2AC(skb->priority) + 1] = 0;
else
--
2.30.2
next prev parent reply other threads:[~2024-06-12 3:22 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 3:22 [PATCH v2 00/24] Staging: rtl8192e: Maintenance renames and cleanup Tree Davies
2024-06-12 3:22 ` [PATCH v2 01/24] Staging: rtl8192e: Rename variable bHwSec Tree Davies
2024-06-12 3:22 ` Tree Davies [this message]
2024-06-12 3:22 ` [PATCH v2 03/24] Staging: rtl8192e: Rename variable HTCurrentOperaRate Tree Davies
2024-06-12 3:22 ` [PATCH v2 04/24] Staging: rtl8192e: Rename variable HTOpMode Tree Davies
2024-06-12 3:22 ` [PATCH v2 05/24] Staging: rtl8192e: Rename variable bRTSEnable Tree Davies
2024-06-12 3:22 ` [PATCH v2 06/24] Staging: rtl8192e: Rename variable bRTSBW Tree Davies
2024-06-12 3:22 ` [PATCH v2 07/24] Staging: rtl8192e: Rename variable bCTSEnable Tree Davies
2024-06-12 3:22 ` [PATCH v2 08/24] Staging: rtl8192e: Rename variable bRTSUseShortGI Tree Davies
2024-06-12 3:22 ` [PATCH v2 09/24] Staging: rtl8192e: Rename variable bforced_tx20Mhz Tree Davies
2024-06-12 3:22 ` [PATCH v2 10/24] Staging: rtl8192e: Rename variable bPacketBW Tree Davies
2024-06-12 3:22 ` [PATCH v2 11/24] Staging: rtl8192e: Rename variable bBroadcast Tree Davies
2024-06-12 3:22 ` [PATCH v2 12/24] Staging: rtl8192e: Rename variable CntAfterLink Tree Davies
2024-06-12 3:22 ` [PATCH v2 13/24] Staging: rtl8192e: Rename variable bUseShortGI Tree Davies
2024-06-12 3:22 ` [PATCH v2 14/24] Staging: rtl8192e: Rename function TsStartAddBaProcess() Tree Davies
2024-06-12 3:22 ` [PATCH v2 15/24] Staging: rtl8192e: Fix alignment to match open parenthesis Tree Davies
2024-06-12 3:22 ` [PATCH v2 16/24] Staging: rtl8192e: Rename function rtllib_query_BandwidthMode Tree Davies
2024-06-12 3:22 ` [PATCH v2 17/24] Staging: rtl8192e: Rename function rtllib_query_ShortPreambleMode Tree Davies
2024-06-12 3:22 ` [PATCH v2 18/24] Staging: rtl8192e: Rename function rtllib_query_HTCapShortGI Tree Davies
2024-06-12 3:22 ` [PATCH v2 19/24] Staging: rtl8192e: Rename variable bUseShortPreamble Tree Davies
2024-06-12 3:22 ` [PATCH v2 20/24] Staging: rtl8192e: Rename variable bRTSSTBC Tree Davies
2024-06-12 3:22 ` [PATCH v2 21/24] Staging: rtl8192e: Remove parameter bIsAmsdu from rtllib_classify() Tree Davies
2024-06-12 3:22 ` [PATCH v2 22/24] Staging: rtl8192e: Remove variable IsAmsdu from rtllib_xmit_inter() Tree Davies
2024-06-12 3:22 ` [PATCH v2 23/24] Staging: rtl8192e: Fix alignment to match open parenthesis in rtllib_tx.c Tree Davies
2024-06-12 3:22 ` [PATCH v2 24/24] Staging: rtl8192e: Fix alignment to match open parenthesis in rtllib_rx.c Tree Davies
2024-06-12 7:02 ` [PATCH v2 00/24] Staging: rtl8192e: Maintenance renames and cleanup Dan Carpenter
2024-06-13 4:13 ` Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240612032230.9738-3-tdavies@darkphysics.net \
--to=tdavies@darkphysics.net \
--cc=anjan@momi.ca \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox