From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
Amit Pundir <amit.pundir@linaro.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Caleb Connolly <caleb.connolly@linaro.org>
Subject: [PATCH v9 1/5] PCI: Hold the rescan mutex when scanning for the first time
Date: Wed, 12 Jun 2024 10:20:14 +0200 [thread overview]
Message-ID: <20240612082019.19161-2-brgl@bgdev.pl> (raw)
In-Reply-To: <20240612082019.19161-1-brgl@bgdev.pl>
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
With the introduction of PCI device power control drivers that will be
able to trigger the port rescan when probing, we need to hold the rescan
mutex during the initial pci_host_probe() too or the two could get in
each other's way.
Tested-by: Amit Pundir <amit.pundir@linaro.org>
Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8550-QRD, SM8650-QRD & SM8650-HDK
Tested-by: Caleb Connolly <caleb.connolly@linaro.org> # OnePlus 8T
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
drivers/pci/probe.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
index bfeeaf2d1fa9..b14b9876c030 100644
--- a/drivers/pci/probe.c
+++ b/drivers/pci/probe.c
@@ -3083,7 +3083,9 @@ int pci_host_probe(struct pci_host_bridge *bridge)
struct pci_bus *bus, *child;
int ret;
+ pci_lock_rescan_remove();
ret = pci_scan_root_bus_bridge(bridge);
+ pci_unlock_rescan_remove();
if (ret < 0) {
dev_err(bridge->dev.parent, "Scanning root bridge failed");
return ret;
--
2.40.1
next prev parent reply other threads:[~2024-06-12 8:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 8:20 [PATCH v9 0/5] PCI/pwrctl: initial implementation and first user Bartosz Golaszewski
2024-06-12 8:20 ` Bartosz Golaszewski [this message]
2024-06-12 8:20 ` [PATCH v9 2/5] PCI/pwrctl: Reuse the OF node for power controlled devices Bartosz Golaszewski
2024-06-12 8:20 ` [PATCH v9 3/5] PCI/pwrctl: Create platform devices for child OF nodes of the port node Bartosz Golaszewski
2024-06-12 8:20 ` [PATCH v9 4/5] PCI/pwrctl: Add PCI power control core code Bartosz Golaszewski
2025-06-17 23:35 ` Bjorn Helgaas
2025-06-18 7:56 ` Bartosz Golaszewski
2024-06-12 8:20 ` [PATCH v9 5/5] PCI/pwrctl: Add a PCI power control driver for power sequenced devices Bartosz Golaszewski
2024-06-12 11:21 ` [PATCH v9 0/5] PCI/pwrctl: initial implementation and first user Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240612082019.19161-2-brgl@bgdev.pl \
--to=brgl@bgdev.pl \
--cc=amit.pundir@linaro.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=bhelgaas@google.com \
--cc=caleb.connolly@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox