public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Potin Lai <potin.lai.pt@gmail.com>
Cc: Corey Minyard <minyard@acm.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Quan Nguyen <quan@os.amperecomputing.com>,
	openipmi-developer@lists.sourceforge.net,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Patrick Williams <patrick@stwcx.xyz>,
	Cosmo Chou <cosmo.chou@quantatw.com>,
	Potin Lai <potin.lai@quantatw.com>
Subject: Re: [PATCH 1/2] bindings: ipmi: Add property for skipping SBMR boot progress response
Date: Thu, 13 Jun 2024 11:59:46 -0600	[thread overview]
Message-ID: <20240613175946.GA2085029-robh@kernel.org> (raw)
In-Reply-To: <20240612043255.1849007-2-potin.lai.pt@gmail.com>

On Wed, Jun 12, 2024 at 12:32:54PM +0800, Potin Lai wrote:
> In ARM Server Base Manageability Requirements (SBMR) document, Callers can
> choose to not read back Response Data after sending the command "Send Boot
> Progress Code".

Got a link to that document?

> Define "arm-sbmr,skip-bootprogress-response" property for skipping the
> response of "Send Boot Progress Code" from userspace.

I don't understand why this would be conditional? How can you define in 
the BMC what the host behavior is? Doesn't the host side decide 
that? So don't you always have to support no response?

> 
> Signed-off-by: Potin Lai <potin.lai.pt@gmail.com>
> ---
>  Documentation/devicetree/bindings/ipmi/ssif-bmc.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/ipmi/ssif-bmc.yaml b/Documentation/devicetree/bindings/ipmi/ssif-bmc.yaml
> index 02b662d780bbb..b21e958efc184 100644
> --- a/Documentation/devicetree/bindings/ipmi/ssif-bmc.yaml
> +++ b/Documentation/devicetree/bindings/ipmi/ssif-bmc.yaml
> @@ -19,6 +19,11 @@ properties:
>    reg:
>      maxItems: 1
>  
> +  arm-sbmr,skip-bootprogress-response:

Form is vendor,property-name where vendor is defined in 
vendor-prefixes.yaml. 'arm-sbmr' is not a vendor.

> +    type: boolean
> +    description:
> +      Skipping ARM SBMR “Send Boot Progress Code” response.
> +
>  required:
>    - compatible
>    - reg
> -- 
> 2.31.1
> 

  reply	other threads:[~2024-06-13 17:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-12  4:32 [PATCH 0/2] ipmi: ssif_bmc: add support of skipping ARM SBMR boot progress response Potin Lai
2024-06-12  4:32 ` [PATCH 1/2] bindings: ipmi: Add property for skipping " Potin Lai
2024-06-13 17:59   ` Rob Herring [this message]
2024-06-13 18:55     ` Corey Minyard
2024-06-12  4:32 ` [PATCH 2/2] ipmi: ssif_bmc: support skipping ARM SBMR bootprogress response Potin Lai
2024-06-14  2:29   ` Quan Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240613175946.GA2085029-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=cosmo.chou@quantatw.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minyard@acm.org \
    --cc=openipmi-developer@lists.sourceforge.net \
    --cc=patrick@stwcx.xyz \
    --cc=potin.lai.pt@gmail.com \
    --cc=potin.lai@quantatw.com \
    --cc=quan@os.amperecomputing.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox