From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: masahiroy@kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, "Danny Lin" <danny@kdrag0n.dev>,
"Íñigo Huguet" <ihuguet@redhat.com>,
"Mickaël Salaün" <mic@digikod.net>,
"Vincent Mailhol" <mailhol.vincent@wanadoo.fr>
Subject: Re: [PATCH v2] .editorconfig: remove trim_trailing_whitespace option
Date: Thu, 13 Jun 2024 08:38:19 +0200 [thread overview]
Message-ID: <2024061340-chair-reliably-7b65@gregkh> (raw)
In-Reply-To: <877cetjrkh.fsf@intel.com>
On Thu, Jun 13, 2024 at 09:16:14AM +0300, Jani Nikula wrote:
> On Tue, 11 Jun 2024, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> > Some editors (like the vim variants), when seeing "trim_whitespace"
> > decide to do just that for all of the whitespace in the file you are
> > saving, even if it is not on a line that you have modified. This plays
> > havoc with diffs and is NOT something that should be intended.
> >
> > As the "only trim whitespace on modified files" is not part of the
>
> Do you mean s/files/lines/?
Yes. I'll edit this when I commit it as it's driving me crazy already
and I think it needs to get to Linus "soon" before we start to see lots
of busted patches sent to maintainers...
thanks,
greg k-h
prev parent reply other threads:[~2024-06-13 6:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 7:27 [PATCH v2] .editorconfig: remove trim_trailing_whitespace option Greg Kroah-Hartman
2024-06-11 8:16 ` Vincent MAILHOL
2024-06-13 6:16 ` Jani Nikula
2024-06-13 6:38 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024061340-chair-reliably-7b65@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=danny@kdrag0n.dev \
--cc=ihuguet@redhat.com \
--cc=jani.nikula@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=masahiroy@kernel.org \
--cc=mic@digikod.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox