From: Hao Ge <hao.ge@linux.dev>
To: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com
Cc: shenghao-ding@ti.com, colin.i.king@gmail.com,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
Hao Ge <gehao@kylinos.cn>
Subject: [PATCH] ASoc: PCM6240: Fix a null pointer dereference in pcmdevice_i2c_probe
Date: Fri, 14 Jun 2024 10:41:16 +0800 [thread overview]
Message-ID: <20240614024116.22130-1-hao.ge@linux.dev> (raw)
From: Hao Ge <gehao@kylinos.cn>
When devm_kzalloc return NULL,we return -ENOMEM directly to
avoid a null pointer that call pcmdevice_remove which will
perform some operations on the members of the pcm_dev;
Fixes: 1324eafd37aa ("ASoc: PCM6240: Create PCM6240 Family driver code")
Signed-off-by: Hao Ge <gehao@kylinos.cn>
---
sound/soc/codecs/pcm6240.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/sound/soc/codecs/pcm6240.c b/sound/soc/codecs/pcm6240.c
index 86e126783a1d..d3adcea457a2 100644
--- a/sound/soc/codecs/pcm6240.c
+++ b/sound/soc/codecs/pcm6240.c
@@ -2088,8 +2088,7 @@ static int pcmdevice_i2c_probe(struct i2c_client *i2c)
pcm_dev = devm_kzalloc(&i2c->dev, sizeof(*pcm_dev), GFP_KERNEL);
if (!pcm_dev) {
- ret = -ENOMEM;
- goto out;
+ return -ENOMEM;
}
pcm_dev->chip_id = (id != NULL) ? id->driver_data : 0;
--
2.25.1
next reply other threads:[~2024-06-14 2:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 2:41 Hao Ge [this message]
2024-06-14 20:20 ` [PATCH] ASoc: PCM6240: Fix a null pointer dereference in pcmdevice_i2c_probe Markus Elfring
2024-06-17 11:58 ` Mark Brown
2024-06-15 6:16 ` Markus Elfring
2024-06-17 2:09 ` [PATCH v2] ASoc: PCM6240: Return directly after a failed devm_kzalloc() in pcmdevice_i2c_probe() Hao Ge
2024-06-23 10:50 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240614024116.22130-1-hao.ge@linux.dev \
--to=hao.ge@linux.dev \
--cc=broonie@kernel.org \
--cc=colin.i.king@gmail.com \
--cc=gehao@kylinos.cn \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=shenghao-ding@ti.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox