From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Teddy Engel <engel.teddy@gmail.com>
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
Philipp Hortmann <philipp.g.hortmann@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/6] staging: rtl8192e: Cleanup multiple issues
Date: Fri, 14 Jun 2024 08:51:30 +0200 [thread overview]
Message-ID: <2024061403-obedient-decoy-d3eb@gregkh> (raw)
In-Reply-To: <CACP1t+uF6R6zDNDsL-ZZOnvWM-t2w097P0tMpxuSsj7=AXvJGA@mail.gmail.com>
On Thu, Jun 13, 2024 at 08:34:37PM +0100, Teddy Engel wrote:
> On Thu, 13 Jun 2024 at 20:22, Dan Carpenter <dan.carpenter@linaro.org>
> wrote:
>
> > On Thu, Jun 13, 2024 at 09:05:03PM +0200, Philipp Hortmann wrote:
> > > On 6/13/24 17:16, Teddy Engel wrote:
> > > > Remove some unused constants, macros, and structs.
> > > > Capitalize a constant.
> > > >
> > > > No specific patch order required.
> > > >
> > > > Teddy Engel (6):
> > > > staging: rtl8192e: Remove unused constant IC_VersionCut_E
> > > > staging: rtl8192e: Remove unused struct phy_ofdm_rx_status_rxsc
> > > > staging: rtl8192e: Remove unused constant WA_IOT_TH_VAL
> > > > staging: rtl8192e: Capitalize constant RegC38_TH
> > > > staging: rtl8192e: Remove unused macro dm_tx_bb_gain_idx_to_amplify
> > > > staging: rtl8192e: Remove unnecessary pre-declaration of struct
> > > > net_device
> > > >
> > > > drivers/staging/rtl8192e/rtl8192e/r8190P_def.h | 8 --------
> > > > drivers/staging/rtl8192e/rtl8192e/rtl_cam.h | 1 -
> > > > drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 4 ++--
> > > > drivers/staging/rtl8192e/rtl8192e/rtl_dm.h | 6 +-----
> > > > drivers/staging/rtl8192e/rtl8192e/rtl_pci.h | 1 -
> > > > 5 files changed, 3 insertions(+), 17 deletions(-)
> > > >
> > >
> > >
> > > Hi Teddy,
> > >
> > > please combine patch 1 and 3 (Remove unused constant ...) . You can
> > change
> > > more than one item in a patch. But it has to be of the same kind.
> > >
> >
> > Could you combine that with the earlier patch that deleted
> > IC_VersionCut_C as well? (Unless that has already been merged).
> >
> > regards,
> > dan carpenter
> >
> > Hey Dan,
>
> I registered to the mailing list (very) recently so unfortunately I don't
> have that change showing in my mail history...
lore.kernel.org has the history of the list since it was started, no
need to be subscribed to see everything that has happened :)
thanks
greg k-h
prev parent reply other threads:[~2024-06-14 6:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 15:16 [PATCH 0/6] staging: rtl8192e: Cleanup multiple issues Teddy Engel
2024-06-13 15:16 ` [PATCH 1/6] staging: rtl8192e: Remove unused constant IC_VersionCut_E Teddy Engel
2024-06-13 15:16 ` [PATCH 2/6] staging: rtl8192e: Remove unused struct phy_ofdm_rx_status_rxsc Teddy Engel
2024-06-13 15:16 ` [PATCH 3/6] staging: rtl8192e: Remove unused constant WA_IOT_TH_VAL Teddy Engel
2024-06-13 15:16 ` [PATCH 4/6] staging: rtl8192e: Capitalize constant RegC38_TH Teddy Engel
2024-06-13 15:16 ` [PATCH 5/6] staging: rtl8192e: Remove unused macro dm_tx_bb_gain_idx_to_amplify Teddy Engel
2024-06-13 15:16 ` [PATCH 6/6] staging: rtl8192e: Remove unnecessary pre-declaration of struct net_device Teddy Engel
2024-06-13 19:05 ` [PATCH 0/6] staging: rtl8192e: Cleanup multiple issues Philipp Hortmann
2024-06-13 19:21 ` Dan Carpenter
2024-06-13 19:58 ` Teddy Engel
[not found] ` <CACP1t+uF6R6zDNDsL-ZZOnvWM-t2w097P0tMpxuSsj7=AXvJGA@mail.gmail.com>
2024-06-14 6:51 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024061403-obedient-decoy-d3eb@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@linaro.org \
--cc=engel.teddy@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox