From: John Garry <john.g.garry@oracle.com>
To: axboe@kernel.dk, paolo.valente@unimore.it
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
jiapeng.chong@linux.alibaba.com, hch@lst.de,
John Garry <john.g.garry@oracle.com>
Subject: [PATCH 0/3] Some block sparse fixes
Date: Fri, 14 Jun 2024 09:03:42 +0000 [thread overview]
Message-ID: <20240614090345.655716-1-john.g.garry@oracle.com> (raw)
Branches for-6.11/block and block-6.10 both have the following sparse
build issues:
block/bdev.c:388:17: warning: symbol 'blockdev_mnt' was not declared.
Should it be static?
block/blk-settings.c:266:9: warning: context imbalance in
'queue_limits_commit_update' - wrong count at exit
block/blk-cgroup.c:834:5: warning: context imbalance in
'blkg_conf_prep' - wrong count at exit
block/blk-cgroup.c:965:9: warning: context imbalance in
'blkg_conf_exit' - wrong count at exit
block/blk-iocost.c:732:9: warning: context imbalance in 'iocg_lock' -
wrong count at exit
block/blk-iocost.c:743:28: warning: context imbalance in 'iocg_unlock'
- unexpected unlock
block/blk-zoned.c:595:30: warning: context imbalance in
'disk_get_and_lock_zone_wplug' - wrong count at exit
block/blk-zoned.c: note: in included file (through include/linux/blkdev.h):
./include/linux/bio.h:592:9: warning: context imbalance in
'blk_zone_wplug_handle_write' - unexpected unlock
block/blk-zoned.c:1747:31: warning: context imbalance in
'blk_revalidate_seq_zone' - unexpected unlock
block/bfq-iosched.c:5498:9: warning: context imbalance in
'bfq_exit_icq' - different lock contexts for basic block
This series contains changes to resolve some of those issues. Some issues
are not addressed, as follows:
- for zoned stuff, as mentioned by Damien at [0], they are not worth
solving
- for blk-iocost.c issues, at [1] Tejun says that lockdep does a better
job (than sparse)
- for blk-cgroup.c issues, at [2] again Tejun says that lockdep does a
better job
I am reposting the patch from Jiapeng Chong, as it was never picked up.
[0] https://lore.kernel.org/linux-block/5e04760e-1334-4514-b2d0-be0d7df33865@kernel.org/
[1] https://lore.kernel.org/linux-block/ZmtwqDsMnTJHQB6o@slm.duckdns.org/
[2] https://lore.kernel.org/lkml/Y7x9t+4EwXFl7OwS@slm.duckdns.org/
Jiapeng Chong (1):
bdev: make blockdev_mnt static
John Garry (2):
block: Drop locking annotation for limits_lock
block: BFQ: Refactor bfq_exit_icq() to silence sparse warning
block/bdev.c | 2 +-
block/bfq-iosched.c | 38 ++++++++++++++++++++------------------
block/blk-settings.c | 1 -
include/linux/blkdev.h | 1 -
4 files changed, 21 insertions(+), 21 deletions(-)
--
2.31.1
next reply other threads:[~2024-06-14 9:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 9:03 John Garry [this message]
2024-06-14 9:03 ` [PATCH 1/3] bdev: make blockdev_mnt static John Garry
2024-06-14 16:35 ` Bart Van Assche
2024-06-14 9:03 ` [PATCH 2/3] block: Drop locking annotation for limits_lock John Garry
2024-06-14 16:36 ` Bart Van Assche
2024-06-14 16:47 ` Christoph Hellwig
2024-06-14 9:03 ` [PATCH 3/3] block: BFQ: Refactor bfq_exit_icq() to silence sparse warning John Garry
2024-06-14 16:37 ` Bart Van Assche
2024-06-16 21:30 ` [PATCH 0/3] Some block sparse fixes Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240614090345.655716-1-john.g.garry@oracle.com \
--to=john.g.garry@oracle.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paolo.valente@unimore.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox