From: Lee Jones <lee@kernel.org>
To: Gregor Herburger <gregor.herburger@ew.tq-group.com>
Cc: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>,
linux-kernel@vger.kernel.org,
Gregor Herburger <gregor.herburger@tq-group.com>,
linux@ew.tq-group.com
Subject: Re: Re: [PATCH 4/4] mfd: tqmx86: add I2C IRQ support
Date: Fri, 14 Jun 2024 10:49:39 +0100 [thread overview]
Message-ID: <20240614094939.GG3029315@google.com> (raw)
In-Reply-To: <ZmwQkHvCdB3rPGEw@herburgerg-w2>
Note: Careful not to cut away too much context when replying.
On Fri, 14 Jun 2024, Gregor Herburger wrote:
> On Thu, Jun 13, 2024 at 04:42:34PM +0100, Lee Jones wrote:
> > Just one question; what is (7, 9, 12)?
> >
> > And why is it the same as the GPIO one? Copy/paste error?
> >
> Those are the IRQ numbers of the PLD. Both blocks, GPIO and I2C, can be
> configured to use IRQ12, IRQ9 or IRQ7.
Might I suggest we make that super clear in the help?
(IRQ7, IRQ9 {and,or} IRQ12)
Or similar.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2024-06-14 9:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 7:03 [PATCH 0/4] mfd: tqmx86: new hardware and GPIO/I2C IRQ improvements/additions Matthias Schiffer
2024-06-05 7:04 ` [PATCH 1/4] mfd: tqmx86: add board definitions for TQMx120UC, TQMx130UC and TQMxE41S Matthias Schiffer
2024-06-05 7:04 ` [PATCH 2/4] mfd: tqmx86: refactor GPIO IRQ setup Matthias Schiffer
2024-06-05 7:04 ` [PATCH 3/4] mfd: tqmx86: make IRQ setup errors non-fatal Matthias Schiffer
2024-06-05 7:04 ` [PATCH 4/4] mfd: tqmx86: add I2C IRQ support Matthias Schiffer
2024-06-13 15:42 ` Lee Jones
2024-06-14 9:42 ` Gregor Herburger
2024-06-14 9:49 ` Lee Jones [this message]
2024-06-17 7:36 ` Matthias Schiffer
2024-06-17 8:54 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240614094939.GG3029315@google.com \
--to=lee@kernel.org \
--cc=gregor.herburger@ew.tq-group.com \
--cc=gregor.herburger@tq-group.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@ew.tq-group.com \
--cc=matthias.schiffer@ew.tq-group.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox