Re: [PATCH v5] binder: use bitmap for faster descriptor lookup

Greg Kroah-Hartman
2024-06-14T09:11:51Z

On Thu, Jun 13, 2024 at 06:50:53PM +0200, Markus Elfring wrote:
> …
> > +++ b/drivers/android/binder.c
> …
> > +static void try_shrink_dmap(struct binder_proc *proc)
> > +{
> …
> > + binder_proc_lock(proc);
> > + nbits = dbitmap_shrink_nbits(&proc->dmap);
> > + binder_proc_unlock(proc);
> …
> > + new = bitmap_zalloc(nbits, GFP_KERNEL);
> > + binder_proc_lock(proc);
> > + dbitmap_shrink(&proc->dmap, new, nbits);
> > + binder_proc_unlock(proc);
> > +}
> …
>
> Would you become interested to apply lock guards?
> https://elixir.bootlin.com/linux/v6.10-rc3/source/include/linux/cleanup.h#L124

Hi,

This is the semi-friendly patch-bot of Greg Kroah-Hartman.

Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list. I strongly suggest that you not do this anymore. Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.

Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all. The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback. Please feel free to also ignore emails
from them.

thanks,

greg k-h's patch email bot