Re: [PATCH 5.4 000/202] 5.4.278-rc1 review

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Thu, Jun 13, 2024 at 09:35:07AM -0700, Guenter Roeck wrote:
> On Thu, Jun 13, 2024 at 01:31:38PM +0200, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 5.4.278 release.
> > There are 202 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> > 
> > Responses should be made by Sat, 15 Jun 2024 11:31:50 +0000.
> > Anything received after that time might be too late.
> > 
> 
> net/nfc/nci/core.c:1455:15: error:
>       mixing declarations and code is incompatible with standards before C99
>       [-Werror,-Wdeclaration-after-statement]
>  1455 |         unsigned int hdr_size = NCI_CTRL_HDR_SIZE;
> 
> Maybe enable C99 on older kernel branches ?
> 
> The code is
> 
> +static bool nci_valid_size(struct sk_buff *skb)
> +{
> +       BUILD_BUG_ON(NCI_CTRL_HDR_SIZE != NCI_DATA_HDR_SIZE);
> +       unsigned int hdr_size = NCI_CTRL_HDR_SIZE;
> 
> Swapping those two lines would be another possible fix.

Odd, I fixed this for other branches, but it didn't trigger for me here,
must be a build issue somewhere.

I'll go fix it up now, thanks!

greg k-h