Re: [PATCH PATCH 3/9] perf/x86/intel: Use topology_cpu_type() to get cpu-type

Pawan Gupta
2024-06-17T18:25:54Z

On Mon, Jun 17, 2024 at 11:17:35AM -0700, Dave Hansen wrote:
> On 6/17/24 11:09, Pawan Gupta wrote:
> >> Is this trying to make the case that get_this_hybrid_cpu_type() and
> >> topology_cpu_type() are equivalent or pointing out a difference?
> > Pointing out a difference. get_this_hybrid_cpu_type() misses a case when
> > cpu-type is enumerated regardless of X86_FEATURE_HYBRID_CPU. I don't think
> > checking for the hybrid feature is necessary here, because there is an
> > existing fixup for this case:
>
> OK, that makes sense. Could you include that in the changelog, please?

Sure.