Re: [PATCH 5/5] riscv: dts: sophgo: Add LicheeRV Nano board device tree

Inochi Amaoto
2024-06-10T07:39:01Z

On Mon, Jun 10, 2024 at 09:30:55AM GMT, Thomas Bonnefille wrote:
> Thank you for your answer :)
>
> On 5/28/24 12:25 AM, Inochi Amaoto wrote:
>
> > > +
> > > + aliases {
> > > + serial0 = &uart0;
> > > + };
> > > +
> > > + chosen {
> > > + stdout-path = "serial0:115200n8";
> > > + };
> >
> > It is also better to add all already support nodes, such as gpio,
> > other uart port.
>
> I'm importing, cv18xx.dtsi through sg2002.dtsi, so GPIOs are already
> configured and activated by default.
> For the other peripherals, all of them are, with the default pinctrl, set to
> function that haven't any driver yet (ADC, MIPI, PWM...).
>

You forgot sdhci, which is already support the SD.

> Based on what I just said, I'm not sure to understand what you mean, can you
> be more specific about the changes you want?

I suggest adding aliases for all gpio and uart node. You can check
cv1800b-milkv-duo.dts as an example.