Re: [PATCH 1/5] dt-bindings: interrupt-controller: Add SOPHGO SG2002 plic

Inochi Amaoto
2024-06-17T03:33:19Z

On Mon, Jun 17, 2024 at 12:36:27AM GMT, Yixun Lan wrote:
> hi Thomas:
>
> On 12:28 Mon 27 May , Thomas Bonnefille wrote:
> > Add compatible string for SOPHGO SG2002 Platform-Level Interruter
> > Controller.
> >
> > Signed-off-by: Thomas Bonnefille <thomas.bonnefille@bootlin.com>
> > ---
> > .../devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml b/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml
> > index 709b2211276b..7e1451f9786a 100644
> > --- a/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml
> > +++ b/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml
> > @@ -67,6 +67,7 @@ properties:
> > - allwinner,sun20i-d1-plic
> > - sophgo,cv1800b-plic
> > - sophgo,cv1812h-plic
> > + - sophgo,sg2002-plic
>
> it's not necessary to introduce a new compatible name, as sg2002 use same plic IP as cv1800b
> I feel it's wrong to introduce sophgo,cv1812h-plic at first place, but that we can't revert?
>
> same reason also apply to clint in patch 2/5 ..
>

You are right, it is historical reasons. For hardware, they have the same risc-v cores
across the whole series.

It could be better to use something just like "cv1800-plic".

> > - sophgo,sg2042-plic
> > - thead,th1520-plic
> > - const: thead,c900-plic
> >
> > --
> > 2.45.1
> >
>
> --
> Yixun Lan (dlan)
> Gentoo Linux Developer
> GPG Key ID AABEFD55