Re: [PATCH net-next v15 02/14] net: Move dev_set_hwtstamp_phylib to net/core/dev.h

Jakub Kicinski
2024-06-18T01:26:43Z

On Wed, 12 Jun 2024 17:04:02 +0200 Kory Maincent wrote:
> This declaration was added to the header to be called from ethtool.
> ethtool is separated from core for code organization but it is not really
> a separate entity, it controls very core things.
> As ethtool is an internal stuff it is not wise to have it in netdevice.h.
> Move the declaration to net/core/dev.h instead.
>
> Remove the EXPORT_SYMBOL_GPL call as ethtool can not be built as a module.
>
> Reviewed-by: Willem de Bruijn <willemb@google.com>
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>

I'll take this one, it stands on its own.