Re: [PATCH net-next v15 07/14] net: Add struct kernel_ethtool_ts_info

Paolo Abeni
2024-06-14T14:02:11Z

On Wed, 2024-06-12 at 17:04 +0200, Kory Maincent wrote:
> In prevision to add new UAPI for hwtstamp we will be limited to the struct
> ethtool_ts_info that is currently passed in fixed binary format through the
> ETHTOOL_GET_TS_INFO ethtool ioctl. It would be good if new kernel code
> already started operating on an extensible kernel variant of that
> structure, similar in concept to struct kernel_hwtstamp_config vs struct
> hwtstamp_config.
>
> Since struct ethtool_ts_info is in include/uapi/linux/ethtool.h, here
> we introduce the kernel-only structure in include/linux/ethtool.h.
> The manual copy is then made in the function called by ETHTOOL_GET_TS_INFO.
>
> Acked-by: Shannon Nelson <shannon.nelson@amd.com>
> Acked-by: Alexandra Winter <wintera@linux.ibm.com>
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>

I think it would be nice if a few more vendors could actually step-in
and test/ack the driver specific bits.

Thanks,

Paolo