Re: [PATCH v3 4/5] drm/msm/adreno: Move hwcg table into a6xx specific info

Konrad Dybcio
2024-06-18T11:13:14Z

On 6/18/24 00:51, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> Introduce a6xx_info where we can stash gen specific stuff without
> polluting the toplevel adreno_info struct.
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
> drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 65 +++++++++++++++++------
> drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 6 +--
> drivers/gpu/drm/msm/adreno/a6xx_gpu.h | 9 ++++
> drivers/gpu/drm/msm/adreno/adreno_gpu.h | 6 ++-
> 4 files changed, 67 insertions(+), 19 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c b/drivers/gpu/drm/msm/adreno/a6xx_catalog.c
> index bcc2f4d8cfc6..96d93251fdd6 100644
> --- a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c
> +++ b/drivers/gpu/drm/msm/adreno/a6xx_catalog.c
> @@ -7,6 +7,7 @@
> */
>
> #include "adreno_gpu.h"
> +#include "a6xx_gpu.h"
> #include "a6xx.xml.h"
> #include "a6xx_gmu.xml.h"
>
> @@ -465,7 +466,9 @@ static const struct adreno_info a6xx_gpus[] = {
> .inactive_period = DRM_MSM_INACTIVE_PERIOD,
> .init = a6xx_gpu_init,
> .zapfw = "a610_zap.mdt",
> - .hwcg = a612_hwcg,
> + .a6xx = &(struct a6xx_info) {

const

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad