From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5CA61A2FDA; Tue, 18 Jun 2024 12:40:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718714447; cv=none; b=Jev7eJFOCshERCJCf4UJLUjKhqHe+xM/KqrWKPqFumkxb3b4G4UPos9vhEUubLd5S3DP0GWHqgn1atHq3KY3ibp+RGCT0g792OYyv7Lp73MtLjONTp0zj0pbgEizoKjqV99yGBqVuHbGt8L0LpO+pwpDNI7GRnUgpVHC4IUKBE0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718714447; c=relaxed/simple; bh=6YK1nSfeH51EVhdHDofsARKpTId9VzEdXwFMFFgqiWc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Q6mSc/z1p8A5DDYESyhhLzOccydB394bqYknAvSI6RrTx+Sac9CYIzDS6vVInnoRM1X4TcBFXp7BiWO38KGuMZ+z3XBuc349aq8fSs3O/9WjnsPy33Ico/wjJREEjB1mK8Dxbp1iWVKjQ5qjpS8kuchXMIrE4BlSalmIvA7KNR8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lA4yl44N; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lA4yl44N" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D360C3277B; Tue, 18 Jun 2024 12:40:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718714447; bh=6YK1nSfeH51EVhdHDofsARKpTId9VzEdXwFMFFgqiWc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lA4yl44NgXyJR7WslrDTVKT/fFiDEMzjl3Ubplolu3qq1l8RagfmDJc/lBVeZEe9X 2k7E9VvjhqG9CV90aJznECG3crq37kodDv0maf3puWkk0u0UHZq50RsND+W92tQinG 2rRg50L8b9+Rjf4bj692Z6ui+GnUmJ+YhEYQuyiLHkvoUvqBF16HIqv1lgg5a7wR9z kuIcD00uT3nrVaWEWyEJX18GccG52Z+MYUo7vh1Sad3XKnV0tFPj3vLwEUtsEMQg15 926peG7E9XQrCMZ3gdets/EUpyRLbjnZjhVhmWn8ch+qLlMqhxjbI77oFSSspgRNJ+ zb5Ho/QA5Yw+w== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yedidya Benshimol , Gregory Greenman , Miri Korenblit , Johannes Berg , Sasha Levin , kvalo@kernel.org, shaul.triebitz@intel.com, benjamin.berg@intel.com, linux-wireless@vger.kernel.org Subject: [PATCH AUTOSEL 6.1 15/29] wifi: iwlwifi: mvm: d3: fix WoWLAN command version lookup Date: Tue, 18 Jun 2024 08:39:41 -0400 Message-ID: <20240618124018.3303162-15-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240618124018.3303162-1-sashal@kernel.org> References: <20240618124018.3303162-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.1.94 Content-Transfer-Encoding: 8bit From: Yedidya Benshimol [ Upstream commit b7ffca99313d856f7d1cc89038d9061b128e8e97 ] After moving from commands to notificaitons in the d3 resume flow, removing the WOWLAN_GET_STATUSES and REPLY_OFFLOADS_QUERY_CMD causes the return of the default value when looking up their version. Returning zero here results in the driver sending the not supported NON_QOS_TX_COUNTER_CMD. Signed-off-by: Yedidya Benshimol Reviewed-by: Gregory Greenman Signed-off-by: Miri Korenblit Link: https://msgid.link/20240510170500.8cabfd580614.If3a0db9851f56041f8f5360959354abd5379224a@changeid Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin --- drivers/net/wireless/intel/iwlwifi/mvm/d3.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/d3.c b/drivers/net/wireless/intel/iwlwifi/mvm/d3.c index 88f4f429d875c..9a36ce98b5bfc 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/d3.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/d3.c @@ -1934,7 +1934,8 @@ static bool iwl_mvm_setup_connection_keep(struct iwl_mvm *mvm, out: if (iwl_fw_lookup_notif_ver(mvm->fw, LONG_GROUP, - WOWLAN_GET_STATUSES, 0) < 10) { + WOWLAN_GET_STATUSES, + IWL_FW_CMD_VER_UNKNOWN) < 10) { mvmvif->seqno_valid = true; /* +0x10 because the set API expects next-to-use, not last-used */ mvmvif->seqno = status->non_qos_seq_ctr + 0x10; -- 2.43.0