Re: [tip: x86/urgent] x86/resctrl: Don't try to free nonexistent RMIDs

Dave Martin
2024-06-19T16:03:07Z

Hi Boris,

On Wed, Jun 19, 2024 at 03:45:22PM +0200, Borislav Petkov wrote:
> On Wed, Jun 19, 2024 at 01:51:34PM +0100, Dave Martin wrote:
> > This commit message now looks a mess on a regular terminal, since git
> > log indents the start of each line by four columns.
>
> Well, we got rid of the 80 cols rule a long time ago so if you're looking at
> kernel code in that same terminal, you're looking at a similar mess?

<bikeshed>

It's still a guideline, no? (Though I admit that common sense has to
apply and there are quite often good reasons to bust the limit in
code.) But commit messages are not code, and don't suffer from
creeping indentation that eats up half of each line, so the rationale
is not really the same.

In block text, lines near maximum length are common, but when looking at
code OTOH, long lines are usually rare, so the file is not rendered
unreadable without linewrap turned off or a bigger terminal.

For git logs, git config core.pager 'less -S' makes things a little
better I suppose, since that at least keeps the left-hand columns blank
on the commit message lines, making the log easier to skim through by
eye. There doesn't seem to be a way to bind a key to flip line
wrapping on and off in less at runtime, though I've not dug into it.

</bikeshed>

Anyway, I was just mildly surprised, it's not a huge deal.

> --
> Regards/Gruss,
> Boris.
>
> https://people.kernel.org/tglx/notes-about-netiquette

(Quoted: "Text-based e-mail should not exceed 80 columns per line of
text. Consult the documentation of your e-mail client to enable proper
line breaks around column 78.". No statement about commit messages,
and "should not exceed" is not the same as "should be wrapped to".
This document doesn't seem to consider how git formats text derived
from emails.)

Cheers
---Dave