Re: [PATCH] LoongArch: uprobes: make UPROBE_SWBP_INSN/UPROBE_XOLBP_INSN constant

Huacai Chen
2024-06-29T13:49:03Z

On Sat, Jun 29, 2024 at 9:40 PM Oleg Nesterov <oleg@redhat.com> wrote:
>
> On 06/29, Tiezhu Yang wrote:
> >
> > On Thu, 27 Jun 2024 19:38:06 +0200
> > Oleg Nesterov <oleg@redhat.com> wrote:
> >
> > ...
> >
> > > > > +arch_initcall(check_emit_break);
> > > > > +
> > > >
> > > > I wouldn't even bother with this, but whatever.
> > >
> > > Agreed, this looks a bit ugly. I did this only because I can not test
> > > this (hopefully trivial) patch and the maintainers didn't reply.
> >
> > The LoongArch maintainer Huacai told me offline to reply this thread today.
> >
> > > If LoongArch boots at least once with this change, this run-time check
> > > can be removed.
> >
> > I will test it next Monday.
>
> Thanks!
>
> > > And just in case... I didn't dare to make a more "generic" change, but
> > > perhaps KPROBE_BP_INSN and KPROBE_SSTEPBP_INSN should be redefined the
> > > same way for micro-optimization. In this case __emit_break() should be
> > > probably moved into arch/loongarch/include/asm/inst.h.
> >
> > Yeah. I think so too.
>
> OK... should I send v2? Or another change which does this on top of this
> patch? Or will you do it yourself?
I prefer V2.

Huacai
>
> >
> > Thanks,
> > Tiezhu
> >
>