public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: linux-hwmon@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
	"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
	"René Rebe" <rene@exactcode.de>,
	"Thomas Weißschuh" <linux@weissschuh.net>,
	"Armin Wolf" <W_Armin@gmx.de>,
	"Stephen Horvath" <s.horvath@outlook.com.au>,
	"Paul Menzel" <pmenzel@molgen.mpg.de>,
	"Sasha Kozachuk" <skozachuk@google.com>,
	"John Hamrick" <johnham@google.com>,
	"Chris Sarra" <chrissarra@google.com>,
	"Guenter Roeck" <linux@roeck-us.net>
Subject: [RFT PATCH v2 0/3] hwmon: (spd5118) Various improvements
Date: Tue, 18 Jun 2024 12:53:45 -0700	[thread overview]
Message-ID: <20240618195348.1670547-1-linux@roeck-us.net> (raw)

The first patch of this series introduces multi-page support using the
regmap infrastructure. This simplifies the code and improves regmap caching.

The second patch introduces a spd5118-specific regmap bus to implement
SMBus accesses. This solves a problem seen with i801 I2C controllers
when writing to the chip. The I2C_FUNC_SMBUS_I2C_BLOCK support implemented
in those controllers does not work with spd5118 compatible chips, so
byte-by-byte access needs to be used explicitly.

The third patch adds support for spd5118 compatible chips which follow
the standard literally and block access to volatile registers if not
on page 0.

RFT: I was able to test the code on AMD systems using the piix4 I2C
controller. It needs testing with i801 controllers and with Renesas
chips.

v2: Added patches 1 and 2; simplified patch 3 to rely on regmap
    based paging.

----------------------------------------------------------------
Guenter Roeck (3):
      hwmon: (spd5118) Use regmap to implement paging
      hwmon: (spd5118) Use spd5118 specific read/write operations
      hwmon: (spd5118) Add support for Renesas/ITD SPD5118 hub controllers

 drivers/hwmon/Kconfig   |   2 +-
 drivers/hwmon/spd5118.c | 131 +++++++++++++++++++++++++++++++++++++-----------
 2 files changed, 102 insertions(+), 31 deletions(-)

             reply	other threads:[~2024-06-18 19:53 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-18 19:53 Guenter Roeck [this message]
2024-06-18 19:53 ` [RFT PATCH v2 1/3] hwmon: (spd5118) Use regmap to implement paging Guenter Roeck
2024-06-18 19:53 ` [RFT PATCH v2 2/3] hwmon: (spd5118) Use spd5118 specific read/write operations Guenter Roeck
2024-06-18 20:37   ` Paul Menzel
2024-06-18 21:08     ` Guenter Roeck
2024-06-18 21:45       ` Paul Menzel
2024-06-18 22:37         ` Guenter Roeck
2024-06-18 22:59           ` Paul Menzel
2024-06-18 22:28       ` Wolfram Sang
2024-06-18 23:28         ` Armin Wolf
2024-06-18 23:39           ` Paul Menzel
2024-06-19  0:23             ` Guenter Roeck
2024-06-19  0:50               ` Thomas Weißschuh
2024-06-19  1:02                 ` Guenter Roeck
2024-06-19  9:13                   ` Thomas Weißschuh
2024-06-19 14:18                     ` Guenter Roeck
2024-06-18 19:53 ` [RFT PATCH v2 3/3] hwmon: (spd5118) Add support for Renesas/ITD SPD5118 hub controllers Guenter Roeck
2024-06-18 20:59 ` [RFT PATCH v2 0/3] hwmon: (spd5118) Various improvements Armin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240618195348.1670547-1-linux@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=W_Armin@gmx.de \
    --cc=chrissarra@google.com \
    --cc=johnham@google.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@weissschuh.net \
    --cc=pmenzel@molgen.mpg.de \
    --cc=rene@exactcode.de \
    --cc=s.horvath@outlook.com.au \
    --cc=skozachuk@google.com \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox