Re: [PATCH v4 4/5] dt-bindings: iio: dac: Add adi,ltc2672.yaml

Conor Dooley
2024-06-25T16:20:55Z

[-- Attachment #1: Type: text/plain, Size: 3053 bytes --]

On Tue, Jun 25, 2024 at 03:51:27PM +0000, Paller, Kim Seer wrote:
>
>
> > From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>

> > On Mon, 24 Jun 2024 18:00:24 +0100
> > Conor Dooley <conor@kernel.org> wrote:
> >
> > > On Mon, Jun 24, 2024 at 03:26:26PM +0000, Paller, Kim Seer wrote:
> > > >
> > > >
> > > > > From: Jonathan Cameron <jic23@kernel.org>

> > > > > Subject: Re: [PATCH v4 4/5] dt-bindings: iio: dac: Add adi,ltc2672.yaml
> > > > >
> > > > >
> > > > > On Wed, 19 Jun 2024 18:57:59 +0100
> > > > > Conor Dooley <conor@kernel.org> wrote:
> > > > >
> > > > > > On Wed, Jun 19, 2024 at 02:49:03PM +0800, Kim Seer Paller wrote:
> > > > > > > +patternProperties:
> > > > > > > + "^channel@[0-4]$":
> > > > > > > + type: object
> > > > > > > + additionalProperties: false
> > > > > > > +
> > > > > > > + properties:
> > > > > > > + reg:
> > > > > > > + description: The channel number representing the DAC output
> > > > > channel.
> > > > > > > + maximum: 4
> > > > > > > +
> > > > > > > + adi,toggle-mode:
> > > > > > > + description:
> > > > > > > + Set the channel as a toggle enabled channel. Toggle operation
> > > > > enables
> > > > > > > + fast switching of a DAC output between two different DAC
> > codes
> > > > > without
> > > > > > > + any SPI transaction.
> > > > > > > + type: boolean
> > > > > > > +
> > > > > > > + adi,output-range-microamp:
> > > > > > > + description: Specify the channel output full scale range.
> > > > > > > + enum: [3125000, 6250000, 12500000, 25000000, 50000000,
> > > > > 100000000,
> > > > > > > + 200000000, 300000000]
> > > > > >
> > > > > > IIO folks, is this sort of thing common/likely to exist on other DACs?
> > > > >
> > > > > Fair point. It is probably time to conclude this is at least moderately
> > common
> > > > > and generalize it - which will need a dac.yaml similar to the one we have
> > for
> > > > > ADCs in adc/adc.yaml. That will need to make this a per channel node
> > property
> > > > > (same as the adc ones).
> > > >
> > > > Should I proceed with generalizing common DAC properties in this series
> > and does
> > >
> > > I think so, yes.
> >
> > Yes, that would great.
>
> I was wondering who would be the designated maintainer for new dac.yaml?

I'd suggest Jonathan!

> > > > this mean somehow removing these common properties from existing DAC
> > bindings?
> > >
> > > I think that that one is up to Jonathan.
> >
> > We can deprecate them. At somepoint we can remove them form the
> > documented bindings
> > but we will need to keep them in drivers forever (which won't be costly in this
> > case).

Right. Anything where the name _would change_ needs to be deprecated and
kept forever. I was thinking more about properties that are defined in
multiple locations with the same name, e.g. if "output-range-microvolts"
existed in 6 different bindings.

Thanks,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]