Re: [PATCH v3 2/2] usercopy: Convert test_user_copy to KUnit test

[Kees Cook <kees@kernel.org>]

On Wed, Jun 19, 2024 at 11:38:31AM -0700, Jeff Johnson wrote:
> On 6/12/24 12:59, Kees Cook wrote:
> > Convert the runtime tests of hardened usercopy to standard KUnit tests.
> > 
> > Additionally disable usercopy_test_invalid() for systems with separate
> > address spaces (or no MMU) since it's not sensible to test for address
> > confusion there (e.g. m68k).
> > 
> > Co-developed-by: Vitor Massaru Iha <vitor@massaru.org>
> > Signed-off-by: Vitor Massaru Iha <vitor@massaru.org>
> > Link: https://lore.kernel.org/r/20200721174654.72132-1-vitor@massaru.org
> > Tested-by: Ivan Orlov <ivan.orlov0322@gmail.com>
> > Reviewed-by: David Gow <davidgow@google.com>
> > Signed-off-by: Kees Cook <kees@kernel.org>
> > ---
> ...
> > +kunit_test_suites(&usercopy_test_suite);
> > +MODULE_AUTHOR("Kees Cook <kees@kernel.org>");
> >   MODULE_LICENSE("GPL");
> 
> Can you add the missing MODULE_DESCRIPTION() to remove the W=1 warning?
> 
> The fix to the current file is part of:
> https://lore.kernel.org/all/20240601-md-lib-test-v1-1-a728620e37d8@quicinc.com/

Thanks for the reminder! I've split it out and sent a separate patch to
Shuah.

-- 
Kees Cook