From: Oleg Nesterov <oleg@redhat.com>
To: "Liao, Chang" <liaochang1@huawei.com>
Cc: jolsa@kernel.org, rostedt@goodmis.org, mhiramat@kernel.org,
ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
nathan@kernel.org, peterz@infradead.org, mingo@redhat.com,
mark.rutland@arm.com, linux-perf-users@vger.kernel.org,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next] uprobes: Fix the xol slots reserved for uretprobe trampoline
Date: Thu, 20 Jun 2024 10:36:02 +0200 [thread overview]
Message-ID: <20240620083602.GB30070@redhat.com> (raw)
In-Reply-To: <7cfa9f1f-d9ce-b6bb-3fe0-687fae9c77c4@huawei.com>
On 06/20, Liao, Chang wrote:
>
> However, when i asm porting uretprobe trampoline to arm64
> to explore its benefits on that architecture, i discovered the problem that
> single slot is not large enought for trampoline code.
Ah, but then I'd suggest to make the changelog more clear. It looks as
if the problem was introduced by the patch from Jiri. Note that we was
confused as well ;)
And,
+ /* Reserve enough slots for the uretprobe trampoline */
+ for (slot_nr = 0;
+ slot_nr < max((insns_size / UPROBE_XOL_SLOT_BYTES), 1);
+ slot_nr++)
this doesn't look right. Just suppose that insns_size = UPROBE_XOL_SLOT_BYTES + 1.
I'd suggest DIV_ROUND_UP(insns_size, UPROBE_XOL_SLOT_BYTES).
And perhaps it would be better to send this change along with
uretprobe_trampoline_for_arm64 ?
Oleg.
next prev parent reply other threads:[~2024-06-20 8:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 1:34 [PATCH bpf-next] uprobes: Fix the xol slots reserved for uretprobe trampoline Liao Chang
2024-06-19 14:38 ` Oleg Nesterov
2024-06-20 2:39 ` Liao, Chang
2024-06-20 8:36 ` Oleg Nesterov [this message]
2024-06-20 9:06 ` Jiri Olsa
2024-06-20 11:27 ` Liao, Chang
2024-07-03 8:54 ` Liao, Chang
2024-06-20 9:58 ` Liao, Chang
2024-06-20 10:52 ` Oleg Nesterov
2024-06-20 11:58 ` Liao, Chang
2024-06-19 16:22 ` Jiri Olsa
2024-06-20 2:58 ` Liao, Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240620083602.GB30070@redhat.com \
--to=oleg@redhat.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jolsa@kernel.org \
--cc=liaochang1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=nathan@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox