From: Bjorn Helgaas <helgaas@kernel.org>
To: Anand Moon <linux.amoon@gmail.com>
Cc: "Shawn Lin" <shawn.lin@rock-chips.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Heiko Stuebner" <heiko@sntech.de>,
"kernel test robot" <lkp@intel.com>,
linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] PCI: rockchip: Simplify clock handling by using clk_bulk*() function
Date: Fri, 21 Jun 2024 16:21:25 -0500 [thread overview]
Message-ID: <20240621212125.GA1406213@bhelgaas> (raw)
In-Reply-To: <20240621064426.282048-1-linux.amoon@gmail.com>
On Fri, Jun 21, 2024 at 12:14:20PM +0530, Anand Moon wrote:
> Refactors the clock handling in the Rockchip PCIe driver,
> introducing a more robust and efficient method for enabling and
> disabling clocks using clk_bulk*() API. Using the clk_bulk APIs,
> the clock handling for the core clocks becomes much simpler.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202406200818.CQ7DXNSZ-lkp@intel.com/
Drop these two lines, as suggested in the test robot report:
If you fix the issue in a separate patch/commit (i.e. not just a new
version of the same patch/commit), kindly add following tags ...
This is a new version of the same patch, so it doesn't need those
tags.
The problem you're solving with this patch is that the clock handling
is too complicated. The test robot didn't report *that* problem.
Since you'll repost for this, also s/Refactors/Refactor/ in the commit
log so this is in imperative mood:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=v6.9#n94
https://chris.beams.io/posts/git-commit/
> drivers/pci/controller/pcie-rockchip.c | 64 ++++----------------------
> drivers/pci/controller/pcie-rockchip.h | 15 ++++--
> 2 files changed, 21 insertions(+), 58 deletions(-)
Nice reduction in lines!
next prev parent reply other threads:[~2024-06-21 21:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-21 6:44 [PATCH v2 1/3] PCI: rockchip: Simplify clock handling by using clk_bulk*() function Anand Moon
2024-06-21 6:44 ` [PATCH v2 2/3] PCI: rockchip: Simplify reset control handling by using reset_control_bulk*() function Anand Moon
2024-06-21 6:44 ` [PATCH v2 3/3] PCI: rockchip: Refactor rockchip_pcie_disable_clocks function signature Anand Moon
2024-06-21 21:21 ` Bjorn Helgaas [this message]
2024-06-22 4:29 ` [PATCH v2 1/3] PCI: rockchip: Simplify clock handling by using clk_bulk*() function Anand Moon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240621212125.GA1406213@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=heiko@sntech.de \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux.amoon@gmail.com \
--cc=lkp@intel.com \
--cc=lpieralisi@kernel.org \
--cc=robh@kernel.org \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox