public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Luck <tony.luck@intel.com>
To: Fenghua Yu <fenghua.yu@intel.com>,
	Reinette Chatre <reinette.chatre@intel.com>,
	Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
	Peter Newman <peternewman@google.com>,
	James Morse <james.morse@arm.com>,
	Babu Moger <babu.moger@amd.com>,
	Drew Fustini <dfustini@baylibre.com>,
	Dave Martin <Dave.Martin@arm.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
	patches@lists.linux.dev, Tony Luck <tony.luck@intel.com>
Subject: [PATCH v21 09/18] x86/resctrl: Add a new field to struct rmid_read for summation of domains
Date: Fri, 21 Jun 2024 15:38:50 -0700	[thread overview]
Message-ID: <20240621223859.43471-10-tony.luck@intel.com> (raw)
In-Reply-To: <20240621223859.43471-1-tony.luck@intel.com>

When a user reads a monitor file rdtgroup_mondata_show() calls
mon_event_read() to package up all the required details into an rmid_read
structure which is passed across the smp_call*() infrastructure to code
that will read data from hardware and return the value (or error status)
in the rmid_read structure.

Sub-NUMA Cluster (SNC) mode adds files with new semantics. These require
the smp_call-ed code to sum event data from all domains that share an
L3 cache.

Add a pointer to the L3 "cacheinfo" structure to struct rmid_read
for the data collection routines to use to pick the domains to be
summed.

Reinette suggested that the rmid_read structure has become complex enough
to warrant documentation of each of its fields and provided the kerneldoc
documentation for struct rmid_read.

Co-developed-by: Reinette Chatre <reinette.chatre@intel.com>
Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
---
 arch/x86/kernel/cpu/resctrl/internal.h | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
index 135190e0711c..d04018b8b571 100644
--- a/arch/x86/kernel/cpu/resctrl/internal.h
+++ b/arch/x86/kernel/cpu/resctrl/internal.h
@@ -144,12 +144,31 @@ union mon_data_bits {
 	} u;
 };
 
+/**
+ * struct rmid_read - Data passed across smp_call*() to read event count.
+ * @rgrp:  Resource group for which the counter is being read. If it is a parent
+ *	   resource group then its event count is summed with the count from all
+ *	   its child resource groups.
+ * @r:	   Resource describing the properties of the event being read.
+ * @d:	   Domain that the counter should be read from. If NULL then sum all
+ *	   domains in @r sharing L3 @ci.id
+ * @evtid: Which monitor event to read.
+ * @first: Initialize MBM counter when true.
+ * @ci:    Cacheinfo for L3. Only set when @d is NULL. Used when summing domains.
+ * @err:   Error encountered when reading counter.
+ * @val:   Returned value of event counter. If @rgrp is a parent resource group,
+ *	   @val contains the sum of event counts from its child resource groups.
+ *	   If @d is NULL, @val includes the sum of all domains in @r sharing @ci.id,
+ *	   (summed across child resource groups if @rgrp is a parent resource group).
+ * @arch_mon_ctx: Hardware monitor allocated for this read request (MPAM only).
+ */
 struct rmid_read {
 	struct rdtgroup		*rgrp;
 	struct rdt_resource	*r;
 	struct rdt_mon_domain	*d;
 	enum resctrl_event_id	evtid;
 	bool			first;
+	struct cacheinfo	*ci;
 	int			err;
 	u64			val;
 	void			*arch_mon_ctx;
-- 
2.45.2


  parent reply	other threads:[~2024-06-21 22:39 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-21 22:38 [PATCH v21 00/18] Add support for Sub-NUMA cluster (SNC) systems Tony Luck
2024-06-21 22:38 ` [PATCH v21 01/18] x86/resctrl: Prepare for new domain scope Tony Luck
2024-06-21 22:38 ` [PATCH v21 02/18] x86/resctrl: Prepare to split rdt_domain structure Tony Luck
2024-06-21 22:38 ` [PATCH v21 03/18] x86/resctrl: Prepare for different scope for control/monitor operations Tony Luck
2024-06-21 22:38 ` [PATCH v21 04/18] x86/resctrl: Split the rdt_domain and rdt_hw_domain structures Tony Luck
2024-06-21 22:38 ` [PATCH v21 05/18] x86/resctrl: Add node-scope to the options for feature scope Tony Luck
2024-06-21 22:38 ` [PATCH v21 06/18] x86/resctrl: Introduce snc_nodes_per_l3_cache Tony Luck
2024-06-21 22:38 ` [PATCH v21 07/18] x86/resctrl: Block use of mba_MBps mount option on Sub-NUMA Cluster (SNC) systems Tony Luck
2024-06-25 23:28   ` Reinette Chatre
2024-06-21 22:38 ` [PATCH v21 08/18] x86/resctrl: Prepare for new Sub-NUMA Cluster (SNC) monitor files Tony Luck
2024-06-25 23:28   ` Reinette Chatre
2024-06-21 22:38 ` Tony Luck [this message]
2024-06-25 23:29   ` [PATCH v21 09/18] x86/resctrl: Add a new field to struct rmid_read for summation of domains Reinette Chatre
2024-06-21 22:38 ` [PATCH v21 10/18] x86/resctrl: Refactor mkdir_mondata_subdir() with a helper function Tony Luck
2024-06-21 22:38 ` [PATCH v21 11/18] x86/resctrl: Allocate a new field in union mon_data_bits Tony Luck
2024-06-25 23:29   ` Reinette Chatre
2024-06-21 22:38 ` [PATCH v21 12/18] x86/resctrl: Create Sub-NUMA Cluster (SNC) monitor files Tony Luck
2024-06-25 23:30   ` Reinette Chatre
2024-06-21 22:38 ` [PATCH v21 13/18] x86/resctrl: Handle removing directories in Sub-NUMA Cluster (SNC) mode Tony Luck
2024-06-25 23:31   ` Reinette Chatre
2024-06-21 22:38 ` [PATCH v21 14/18] x86/resctrl: Fill out rmid_read structure for smp_call*() to read a counter Tony Luck
2024-06-25 23:33   ` Reinette Chatre
2024-06-26 19:35     ` Tony Luck
2024-06-26 21:23       ` Reinette Chatre
2024-06-27 17:31         ` Luck, Tony
2024-06-27 17:52           ` Reinette Chatre
2024-06-21 22:38 ` [PATCH v21 15/18] x86/resctrl: Make __mon_event_count() handle sum domains Tony Luck
2024-06-25 23:35   ` Reinette Chatre
2024-06-21 22:38 ` [PATCH v21 16/18] x86/resctrl: Enable shared RMID mode on Sub-NUMA Cluster (SNC) systems Tony Luck
2024-06-25 23:35   ` Reinette Chatre
2024-06-21 22:38 ` [PATCH v21 17/18] x86/resctrl: Sub-NUMA Cluster (SNC) detection Tony Luck
2024-06-21 22:38 ` [PATCH v21 18/18] x86/resctrl: Update documentation with Sub-NUMA cluster changes Tony Luck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240621223859.43471-10-tony.luck@intel.com \
    --to=tony.luck@intel.com \
    --cc=Dave.Martin@arm.com \
    --cc=babu.moger@amd.com \
    --cc=dfustini@baylibre.com \
    --cc=fenghua.yu@intel.com \
    --cc=james.morse@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maciej.wieczor-retman@intel.com \
    --cc=patches@lists.linux.dev \
    --cc=peternewman@google.com \
    --cc=reinette.chatre@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox