From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D207136649 for ; Mon, 24 Jun 2024 11:01:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719226906; cv=none; b=jrgYPzlyNFuPczYUd8vBBPfjO47te77Xm6Dm84QGU1MFLRl8WNOZW+0KSRyo9VbBO71dNNZy0KCZaH/kzKuvyPUVAKpGuwZVXQ8FsnuhIGLv6B4gADcpkgkdJcE/2x7tGIdUAxhGFqKwRSdWr9MxshWUnXDxCB8miOVKvYRXTAU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719226906; c=relaxed/simple; bh=g+UI2h+MbGePnkXweRNbz/BpFp2mvZy8j4UxIIDhLSE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dm4AIWKA6jG0ag43OBn4/WtqY9ZDU9dsBwGH07DU+EqemAhsHFqw0oqmJJglwbnoOxsc3rhVhUufECIXj+u1tA5ckE7kMBIozj2BObys2/EyhrnLKT/775I/Y1A33I9kynd9LSWgWmJhrNSUsA/WSoEtyzeKR0TMqs/CJ2s6efs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=NhEKSraQ; arc=none smtp.client-ip=209.85.208.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="NhEKSraQ" Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-2ec10324791so49918861fa.1 for ; Mon, 24 Jun 2024 04:01:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1719226902; x=1719831702; darn=vger.kernel.org; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Xbk+wnOEmNszGUoP4v3r9GEXmsbbE+/wd4rojn5Lqnw=; b=NhEKSraQ2m7+vetuQcQhJEq/Ty+XV+HIdFQEaDlkgmRIbn607Z6WctVCqsPx9RKf0H ZCL8p7muO8fk6Ov7tBeevYjxuKpDKUfsSfPHSjCLviIgfuQr0Vojmfcp/gQ/d0RFD3Q5 FPPv5gkUT3tlzhscPsWTrrE4UuLBcbTpBbC2BST284anEl/ETKvnQpuNs8SdNpiKo9uI R27W5keEUdeZUI6J3KG5EHmydeBguwdQxpjYCFYRcmeUjWuPoLy2AdmGChtghFNNw5bh oHMtIhcD/cMVlRYWXi9gPtaTKLf8JuhoQ6GxGfWu6xUAmKmV5FrmNqOB33rcGJBQAWV1 suDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719226902; x=1719831702; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Xbk+wnOEmNszGUoP4v3r9GEXmsbbE+/wd4rojn5Lqnw=; b=LneTStxCTpkZyLUdN2+8DJh3CwSAvgLAbXkk1n8iZtQbRB/aNrvq7k4I0E5cRzy6tO bxTMp4eL7DtWmGhF7MeubMogBi/xNDa7tusNtu7uv7ZZMMgA6dqWNSAL7Wd/p8IlfkmF QOnKpJuqdjJEFNnwesX9UoHH3SUZYhvsYyohtW+EQOUVbjy0TOMmXf0SwcEtKu9OieQu LW/UgzxG45Cq8eLT+MIfc7I2igTYgbhf5/8SN4G5FZGLuL1C/uFMKAGXwiDK4XG7jBdP FVNCyJh9OaEjOE/7KoaHVDS5iJdNarYaEoJoMC1jp98iuPkTf0j0fTUehfPhDqv16l7f faRA== X-Forwarded-Encrypted: i=1; AJvYcCXIdEwUfNFSAwX62JJtNsuXxUdBQVUE8+mRj2jfmaR+OuS1K+r0zb1dDJR9U5pwjbn4EQvq8ncON6fvf41dKMHeNolfHBpDRv5Oqqac X-Gm-Message-State: AOJu0YyqDADIcsw9bnd+jBtd7aE2AiU8TZI1GAIySkU0NqTQGd6Szq3n cH3LWagqGdifzKM0wSWqNGTxx7x3ezWUfgx+NhHQ0b4q6w245hZwSbU+wDmf1xA= X-Google-Smtp-Source: AGHT+IHSWtAgQHovXxTzoDGYAhW6mCaubV6lUO2+ifOmfKeJEhvEGMv6lloJzC1GDEF/16hsCBqg+Q== X-Received: by 2002:a2e:b011:0:b0:2ec:5019:becd with SMTP id 38308e7fff4ca-2ec5b2e937amr25874761fa.49.1719226902144; Mon, 24 Jun 2024 04:01:42 -0700 (PDT) Received: from linux-l9pv.suse ([124.11.22.254]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2c819dd0cf7sm6407091a91.48.2024.06.24.04.01.39 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jun 2024 04:01:41 -0700 (PDT) Date: Mon, 24 Jun 2024 19:01:37 +0800 From: joeyli To: Markus Elfring Cc: linux-block@vger.kernel.org, Justin Sanders , Chun-Yi Lee , stable@vger.kernel.org, LKML , "David S. Miller" , Jens Axboe , Kirill Korotaev , Nicolai Stange , Pavel Emelianov Subject: Re: [PATCH v2] aoe: fix the potential use-after-free problem in more places Message-ID: <20240624110137.GI7611@linux-l9pv.suse> References: <20240624064418.27043-1-jlee@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Hi Markus, On Mon, Jun 24, 2024 at 10:40:13AM +0200, Markus Elfring wrote: > > … So they should also use dev_hold() to increase the > > refcnt of skb->dev. > … > > reference counter of “skb->dev”? > Yes, I will update my wording. Thanks! Joey Lee > > … > > Fixes: f98364e92662 ("aoe: fix the potential use-after-free problem in aoecmd_cfg_pkts") > > Would you like to add a “stable tag”? > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/stable-kernel-rules.rst?h=v6.10-rc4#n34 > > > Will an adjusted summary phrase become more helpful? > > Regards, > Markus