Re: [PATCH v9 net-next 14/15] net: Reference bpf_redirect_info via task_struct on PREEMPT_RT.

Sebastian Andrzej Siewior
2024-06-24T07:26:14Z

On 2024-06-21 19:08:40 [-0700], Jakub Kicinski wrote:
> On Thu, 20 Jun 2024 15:22:04 +0200 Sebastian Andrzej Siewior wrote:
> > diff --git a/kernel/fork.c b/kernel/fork.c
> > index 99076dbe27d83..f314bdd7e6108 100644
> > --- a/kernel/fork.c
> > +++ b/kernel/fork.c
> > @@ -2355,6 +2355,7 @@ __latent_entropy struct task_struct *copy_process(
> > RCU_INIT_POINTER(p->bpf_storage, NULL);
> > p->bpf_ctx = NULL;
> > #endif
> > + p->bpf_net_context = NULL;
>
> nit: double space after =
>
> Out of curiosity, do we actually have to clear this pointer?

I don't think so. We never clone a thread within a redirect section so
this can probably go away.

Sebastian