public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dev Jain <dev.jain@arm.com>
To: shuah@kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kselftest@vger.kernel.org, Catalin.Marinas@arm.com,
	will@kernel.org
Cc: broonie@kernel.org, ryan.roberts@arm.com, rob.herring@arm.com,
	mark.rutland@arm.com, linux@armlinux.org.uk,
	suzuki.poulose@arm.com, Anshuman.Khandual@arm.com,
	aneesh.kumar@kernel.org, linux-kernel@vger.kernel.org,
	Dev Jain <dev.jain@arm.com>
Subject: [PATCH v3 5/9] selftests/arm64: Fix build warnings for ptrace
Date: Tue, 25 Jun 2024 17:54:04 +0530	[thread overview]
Message-ID: <20240625122408.1439097-6-dev.jain@arm.com> (raw)
In-Reply-To: <20240625122408.1439097-1-dev.jain@arm.com>

"%s" should have been used in ksft_exit_fail_msg(). Anyways, replace that
with the recently introduced ksft_exit_fail_perror(). Also fix no mention of
type_name in ksft_test_result_skip().

NOTE: This patch can be applied independently of the series, but the
next patch depends on this one.

Fixes: ecaf4d3f734f ("kselftest/arm64: Add test coverage for NT_ARM_TLS")
Fixes: cb5aa6379438 ("kselftest/arm64: Add a smoke test for ptracing hardware break/watch points")
Signed-off-by: Dev Jain <dev.jain@arm.com>
---
 tools/testing/selftests/arm64/abi/ptrace.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/testing/selftests/arm64/abi/ptrace.c b/tools/testing/selftests/arm64/abi/ptrace.c
index abe4d58d731d..c83f0441e9d0 100644
--- a/tools/testing/selftests/arm64/abi/ptrace.c
+++ b/tools/testing/selftests/arm64/abi/ptrace.c
@@ -156,17 +156,17 @@ static void test_hw_debug(pid_t child, int type, const char *type_name)
 		/* Zero is not currently architecturally valid */
 		ksft_test_result(arch, "%s_arch_set\n", type_name);
 	} else {
-		ksft_test_result_skip("%s_arch_set\n");
+		ksft_test_result_skip("%s_arch_set\n", type_name);
 	}
 }
 
 static int do_child(void)
 {
 	if (ptrace(PTRACE_TRACEME, -1, NULL, NULL))
-		ksft_exit_fail_msg("PTRACE_TRACEME", strerror(errno));
+		ksft_exit_fail_perror("PTRACE_TRACEME");
 
 	if (raise(SIGSTOP))
-		ksft_exit_fail_msg("raise(SIGSTOP)", strerror(errno));
+		ksft_exit_fail_perror("raise(SIGSTOP)");
 
 	return EXIT_SUCCESS;
 }
-- 
2.39.2


  parent reply	other threads:[~2024-06-25 12:25 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-25 12:23 [PATCH v3 0/9] A new selftests/ directory for arm compatibility testing Dev Jain
2024-06-25 12:24 ` [PATCH v3 1/9] selftests/arm: Add mm test Dev Jain
2024-06-25 12:24 ` [PATCH v3 2/9] selftests/arm: Add elf test Dev Jain
2024-06-25 12:24 ` [PATCH v3 3/9] selftests: arm, arm64: Use ifdeffery to pull signal infrastructure Dev Jain
2024-06-25 15:42   ` Mark Brown
2024-06-25 12:24 ` [PATCH v3 4/9] selftests/arm: Add signal tests Dev Jain
2024-06-25 18:04   ` Mark Brown
2024-06-25 12:24 ` Dev Jain [this message]
2024-06-25 14:35   ` [PATCH v3 5/9] selftests/arm64: Fix build warnings for ptrace Mark Brown
2024-06-25 12:24 ` [PATCH v3 6/9] selftests/arm64: Split ptrace, use ifdeffery Dev Jain
2024-06-25 18:13   ` Mark Brown
2024-06-25 12:24 ` [PATCH v3 7/9] selftests/arm: Add ptrace test Dev Jain
2024-06-25 12:24 ` [PATCH v3 8/9] selftests/arm: Add ptrace_64 test Dev Jain
2024-06-25 18:18   ` Mark Brown
2024-06-25 12:24 ` [PATCH v3 9/9] selftests: Add build infrastructure along with README Dev Jain
2024-06-25 15:32   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240625122408.1439097-6-dev.jain@arm.com \
    --to=dev.jain@arm.com \
    --cc=Anshuman.Khandual@arm.com \
    --cc=Catalin.Marinas@arm.com \
    --cc=aneesh.kumar@kernel.org \
    --cc=broonie@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=rob.herring@arm.com \
    --cc=ryan.roberts@arm.com \
    --cc=shuah@kernel.org \
    --cc=suzuki.poulose@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox