From: Dev Jain <dev.jain@arm.com>
To: shuah@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kselftest@vger.kernel.org, Catalin.Marinas@arm.com,
will@kernel.org
Cc: broonie@kernel.org, ryan.roberts@arm.com, rob.herring@arm.com,
mark.rutland@arm.com, linux@armlinux.org.uk,
suzuki.poulose@arm.com, Anshuman.Khandual@arm.com,
aneesh.kumar@kernel.org, linux-kernel@vger.kernel.org,
Dev Jain <dev.jain@arm.com>
Subject: [PATCH v3 7/9] selftests/arm: Add ptrace test
Date: Tue, 25 Jun 2024 17:54:06 +0530 [thread overview]
Message-ID: <20240625122408.1439097-8-dev.jain@arm.com> (raw)
In-Reply-To: <20240625122408.1439097-1-dev.jain@arm.com>
For a 32-bit parent debugging a 32-bit child, add tests for reading the
TLS registers, and mangling with the mode bits in CPSR.
Signed-off-by: Dev Jain <dev.jain@arm.com>
---
tools/testing/selftests/arm/abi/ptrace.c | 82 ++++++++++++++++++++++++
tools/testing/selftests/arm/abi/ptrace.h | 57 ++++++++++++++++
2 files changed, 139 insertions(+)
create mode 100644 tools/testing/selftests/arm/abi/ptrace.c
create mode 100644 tools/testing/selftests/arm/abi/ptrace.h
diff --git a/tools/testing/selftests/arm/abi/ptrace.c b/tools/testing/selftests/arm/abi/ptrace.c
new file mode 100644
index 000000000000..2079065c48fd
--- /dev/null
+++ b/tools/testing/selftests/arm/abi/ptrace.c
@@ -0,0 +1,82 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Copyright (C) 2024 ARM Limited.
+ */
+#include <errno.h>
+#include <stdbool.h>
+#include <stddef.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
+#include <unistd.h>
+#include <sys/auxv.h>
+#include <sys/prctl.h>
+#include <sys/ptrace.h>
+#include <sys/types.h>
+#include <sys/uio.h>
+#include <sys/wait.h>
+#include <asm/sigcontext.h>
+#include <asm/ptrace.h>
+
+#include "ptrace.h"
+#include "../../kselftest.h"
+
+#define EXPECTED_TESTS 6
+#define NUM_TLS_REGS 2
+
+static void test_tpidr(pid_t child)
+{
+ unsigned long read_val[NUM_TLS_REGS];
+ struct iovec read_iov;
+ int ret;
+
+ read_iov.iov_base = read_val;
+
+ /* TLS registers must not be accessible */
+ read_iov.iov_len = 2 * sizeof(unsigned long);
+ ret = ptrace(PTRACE_GETREGSET, child, NT_ARM_TLS, &read_iov);
+ ksft_test_result(ret != 0, "cannot read TLS\n");
+}
+
+static void run_tests(pid_t child)
+{
+ test_tpidr(child);
+ test_user_regs(child);
+}
+
+static int do_child(void)
+{
+ if (ptrace(PTRACE_TRACEME, -1, NULL, NULL))
+ ksft_exit_fail_perror("PTRACE_TRACEME");
+
+ if (raise(SIGSTOP))
+ ksft_exit_fail_perror("raise(SIGSTOP)");
+
+ if (raise(SIGSTOP))
+ ksft_exit_fail_perror("raise(SIGSTOP)");
+
+ return EXIT_SUCCESS;
+}
+
+int main(void)
+{
+ int ret = EXIT_SUCCESS;
+ pid_t child;
+
+ srandom(getpid());
+
+ ksft_print_header();
+
+ ksft_set_plan(EXPECTED_TESTS);
+
+ child = fork();
+ if (!child)
+ return do_child();
+
+ if (do_parent(child))
+ ret = EXIT_FAILURE;
+
+ ksft_print_cnts();
+
+ return ret;
+}
diff --git a/tools/testing/selftests/arm/abi/ptrace.h b/tools/testing/selftests/arm/abi/ptrace.h
new file mode 100644
index 000000000000..17ba8aa32726
--- /dev/null
+++ b/tools/testing/selftests/arm/abi/ptrace.h
@@ -0,0 +1,57 @@
+// SPDX-License-Identifier: GPL-2.0-only
+#include "../../arm64/abi/ptrace.h"
+
+/* Do not pull from asm/ptrace.h since the macro names change for 32-bit */
+#define PSR_MODE32_BIT 0x00000010
+#define PSR_MODE_EL1t 0x00000004
+
+static void test_user_regs(pid_t child)
+{
+ unsigned int read_val[18];
+ struct iovec read_iov;
+ int status;
+ int ret;
+
+ read_iov.iov_base = read_val;
+ read_iov.iov_len = 18 * sizeof(unsigned int);
+
+ ret = ptrace(PTRACE_GETREGSET, child, NT_PRSTATUS, &read_iov);
+ ksft_test_result(!ret, "read general-purpose registers\n");
+
+ /* Change a random user register */
+ read_val[2] = read_val[2] + 1;
+ ret = ptrace(PTRACE_SETREGSET, child, NT_PRSTATUS, &read_iov);
+ ksft_test_result(!ret, "set user register\n");
+
+ /* 16th register is the CPSR */
+ read_val[16] &= (~PSR_MODE32_BIT);
+
+ ret = ptrace(PTRACE_SETREGSET, child, NT_PRSTATUS, &read_iov);
+ ksft_test_result(ret, "cannot toggle MODE32 bit\n");
+
+ ret = ptrace(PTRACE_CONT, child, NULL, 0);
+ if (ret) {
+ perror("ptrace");
+ goto error;
+ }
+
+ if (wait(&status) == -1) {
+ perror("wait");
+ goto error;
+ }
+
+ read_val[16] = 0;
+
+ ret = ptrace(PTRACE_GETREGSET, child, NT_PRSTATUS, &read_iov);
+ ksft_test_result(!ret, "read general-purpose registers again\n");
+
+ read_val[16] |= PSR_MODE_EL1t;
+ ret = ptrace(PTRACE_SETREGSET, child, NT_PRSTATUS, &read_iov);
+ ksft_test_result(ret, "cannot escalate privilege\n");
+ return;
+
+error:
+ kill(child, SIGKILL);
+}
+
+
--
2.39.2
next prev parent reply other threads:[~2024-06-25 12:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 12:23 [PATCH v3 0/9] A new selftests/ directory for arm compatibility testing Dev Jain
2024-06-25 12:24 ` [PATCH v3 1/9] selftests/arm: Add mm test Dev Jain
2024-06-25 12:24 ` [PATCH v3 2/9] selftests/arm: Add elf test Dev Jain
2024-06-25 12:24 ` [PATCH v3 3/9] selftests: arm, arm64: Use ifdeffery to pull signal infrastructure Dev Jain
2024-06-25 15:42 ` Mark Brown
2024-06-25 12:24 ` [PATCH v3 4/9] selftests/arm: Add signal tests Dev Jain
2024-06-25 18:04 ` Mark Brown
2024-06-25 12:24 ` [PATCH v3 5/9] selftests/arm64: Fix build warnings for ptrace Dev Jain
2024-06-25 14:35 ` Mark Brown
2024-06-25 12:24 ` [PATCH v3 6/9] selftests/arm64: Split ptrace, use ifdeffery Dev Jain
2024-06-25 18:13 ` Mark Brown
2024-06-25 12:24 ` Dev Jain [this message]
2024-06-25 12:24 ` [PATCH v3 8/9] selftests/arm: Add ptrace_64 test Dev Jain
2024-06-25 18:18 ` Mark Brown
2024-06-25 12:24 ` [PATCH v3 9/9] selftests: Add build infrastructure along with README Dev Jain
2024-06-25 15:32 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240625122408.1439097-8-dev.jain@arm.com \
--to=dev.jain@arm.com \
--cc=Anshuman.Khandual@arm.com \
--cc=Catalin.Marinas@arm.com \
--cc=aneesh.kumar@kernel.org \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=rob.herring@arm.com \
--cc=ryan.roberts@arm.com \
--cc=shuah@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox