public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Aapo Vienamo <aapo.vienamo@linux.intel.com>
Cc: Andy Shevchenko <andy@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpio: graniterapids: Add missing raw_spinlock_init()
Date: Tue, 25 Jun 2024 17:07:36 +0300	[thread overview]
Message-ID: <20240625140736.GV1532424@black.fi.intel.com> (raw)
In-Reply-To: <20240625135343.673745-1-aapo.vienamo@linux.intel.com>

On Tue, Jun 25, 2024 at 04:53:43PM +0300, Aapo Vienamo wrote:
> Add the missing raw_spin_lock_init() call to gnr_gpio_probe().
> 
> Fixes: ecc4b1418e23 ("gpio: Add Intel Granite Rapids-D vGPIO driver")
> Signed-off-by: Aapo Vienamo <aapo.vienamo@linux.intel.com>

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Linus/Bartosz, I wonder if you can take this one directly? Andy is
currently on vacation and mine starts after this week so there is nobody
handling these until August. Thanks!

> ---
>  drivers/gpio/gpio-graniterapids.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpio/gpio-graniterapids.c b/drivers/gpio/gpio-graniterapids.c
> index c693fe05d50f..f2e911a3d2ca 100644
> --- a/drivers/gpio/gpio-graniterapids.c
> +++ b/drivers/gpio/gpio-graniterapids.c
> @@ -296,6 +296,8 @@ static int gnr_gpio_probe(struct platform_device *pdev)
>  	if (!priv)
>  		return -ENOMEM;
>  
> +	raw_spin_lock_init(&priv->lock);
> +
>  	regs = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(regs))
>  		return PTR_ERR(regs);
> -- 
> 2.45.2

  reply	other threads:[~2024-06-25 14:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-25 13:53 [PATCH] gpio: graniterapids: Add missing raw_spinlock_init() Aapo Vienamo
2024-06-25 14:07 ` Mika Westerberg [this message]
2024-06-26  8:18 ` Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240625140736.GV1532424@black.fi.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=aapo.vienamo@linux.intel.com \
    --cc=andy@kernel.org \
    --cc=brgl@bgdev.pl \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox