Re: [PATCH] gpio: graniterapids: Add missing raw_spinlock_init()

Mika Westerberg
2024-06-25T14:08:02Z

On Tue, Jun 25, 2024 at 04:53:43PM +0300, Aapo Vienamo wrote:
> Add the missing raw_spin_lock_init() call to gnr_gpio_probe().
>
> Fixes: ecc4b1418e23 ("gpio: Add Intel Granite Rapids-D vGPIO driver")
> Signed-off-by: Aapo Vienamo <aapo.vienamo@linux.intel.com>

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Linus/Bartosz, I wonder if you can take this one directly? Andy is
currently on vacation and mine starts after this week so there is nobody
handling these until August. Thanks!

> ---
> drivers/gpio/gpio-graniterapids.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpio/gpio-graniterapids.c b/drivers/gpio/gpio-graniterapids.c
> index c693fe05d50f..f2e911a3d2ca 100644
> --- a/drivers/gpio/gpio-graniterapids.c
> +++ b/drivers/gpio/gpio-graniterapids.c
> @@ -296,6 +296,8 @@ static int gnr_gpio_probe(struct platform_device *pdev)
> if (!priv)
> return -ENOMEM;
>
> + raw_spin_lock_init(&priv->lock);
> +
> regs = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(regs))
> return PTR_ERR(regs);
> --
> 2.45.2