From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
John Garry <john.g.garry@oracle.com>,
Will Deacon <will@kernel.org>, James Clark <james.clark@arm.com>,
Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linux.dev>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Yicong Yang <yangyicong@hisilicon.com>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Nick Terrell <terrelln@fb.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Oliver Upton <oliver.upton@linux.dev>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Song Liu <song@kernel.org>,
Ilkka Koskinen <ilkka@os.amperecomputing.com>,
Huacai Chen <chenhuacai@kernel.org>,
Yanteng Si <siyanteng@loongson.cn>,
Sun Haiyong <sunhaiyong@loongson.cn>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1 04/26] perf kmem: Use perf_tool__init
Date: Tue, 25 Jun 2024 10:25:41 -0700 [thread overview]
Message-ID: <20240625172603.900667-5-irogers@google.com> (raw)
In-Reply-To: <20240625172603.900667-1-irogers@google.com>
Reduce the scope of the tool from global/static to just that of the
cmd_kmem function where the session is scoped. Use the perf_tool__init
to initialize default values.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/builtin-kmem.c | 17 ++++++++---------
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/tools/perf/builtin-kmem.c b/tools/perf/builtin-kmem.c
index 859ff018eace..b3cbac40b8c7 100644
--- a/tools/perf/builtin-kmem.c
+++ b/tools/perf/builtin-kmem.c
@@ -986,15 +986,6 @@ static int process_sample_event(const struct perf_tool *tool __maybe_unused,
return err;
}
-static struct perf_tool perf_kmem = {
- .sample = process_sample_event,
- .comm = perf_event__process_comm,
- .mmap = perf_event__process_mmap,
- .mmap2 = perf_event__process_mmap2,
- .namespaces = perf_event__process_namespaces,
- .ordered_events = true,
-};
-
static double fragmentation(unsigned long n_req, unsigned long n_alloc)
{
if (n_alloc == 0)
@@ -1971,6 +1962,7 @@ int cmd_kmem(int argc, const char **argv)
NULL
};
struct perf_session *session;
+ struct perf_tool perf_kmem;
static const char errmsg[] = "No %s allocation events found. Have you run 'perf kmem record --%s'?\n";
int ret = perf_config(kmem_config, NULL);
@@ -1998,6 +1990,13 @@ int cmd_kmem(int argc, const char **argv)
data.path = input_name;
+ perf_tool__init(&perf_kmem, /*ordered_events=*/true);
+ perf_kmem.sample = process_sample_event;
+ perf_kmem.comm = perf_event__process_comm;
+ perf_kmem.mmap = perf_event__process_mmap;
+ perf_kmem.mmap2 = perf_event__process_mmap2;
+ perf_kmem.namespaces = perf_event__process_namespaces;
+
kmem_session = session = perf_session__new(&data, &perf_kmem);
if (IS_ERR(session))
return PTR_ERR(session);
--
2.45.2.741.gdbec12cfda-goog
next prev parent reply other threads:[~2024-06-25 17:26 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 17:25 [PATCH v1 00/26] Constify tool pointers Ian Rogers
2024-06-25 17:25 ` [PATCH v1 01/26] perf tool: " Ian Rogers
2024-06-25 17:25 ` [PATCH v1 02/26] perf tool: Move fill defaults into tool.c Ian Rogers
2024-06-25 17:25 ` [PATCH v1 03/26] perf tool: Add perf_tool__init Ian Rogers
2024-06-25 17:25 ` Ian Rogers [this message]
2024-06-25 17:25 ` [PATCH v1 05/26] perf buildid-list: Use perf_tool__init Ian Rogers
2024-06-25 17:25 ` [PATCH v1 06/26] perf kvm: " Ian Rogers
2024-06-25 17:25 ` [PATCH v1 07/26] perf lock: " Ian Rogers
2024-06-25 17:25 ` [PATCH v1 08/26] perf evlist: " Ian Rogers
2024-06-25 17:25 ` [PATCH v1 09/26] perf record: " Ian Rogers
2024-06-25 17:25 ` [PATCH v1 10/26] perf c2c: " Ian Rogers
2024-06-25 17:25 ` [PATCH v1 11/26] perf script: " Ian Rogers
2024-06-25 17:25 ` [PATCH v1 12/26] perf inject: " Ian Rogers
2024-06-25 17:25 ` [PATCH v1 13/26] perf report: " Ian Rogers
2024-06-25 17:25 ` [PATCH v1 14/26] perf stat: " Ian Rogers
2024-06-25 17:25 ` [PATCH v1 15/26] perf annotate: " Ian Rogers
2024-06-25 17:25 ` [PATCH v1 16/26] perf sched: " Ian Rogers
2024-06-25 17:25 ` [PATCH v1 17/26] perf mem: " Ian Rogers
2024-06-25 17:25 ` [PATCH v1 18/26] perf timechart: " Ian Rogers
2024-06-25 17:25 ` [PATCH v1 19/26] perf diff: " Ian Rogers
2024-06-25 17:25 ` [PATCH v1 20/26] perf data convert json: " Ian Rogers
2024-06-25 17:25 ` [PATCH v1 21/26] perf data convert ctf: " Ian Rogers
2024-06-25 17:25 ` [PATCH v1 22/26] perf auxevent: Add explicit dummy tool initialization Ian Rogers
2024-06-26 6:59 ` Adrian Hunter
2024-06-26 17:54 ` Ian Rogers
2024-06-25 17:26 ` [PATCH v1 23/26] perf test event_update: Ensure tools is initialized Ian Rogers
2024-06-25 17:26 ` [PATCH v1 24/26] perf kwork: Use perf_tool__init Ian Rogers
2024-06-25 17:26 ` [PATCH v1 25/26] perf tool: Remove perf_tool__fill_defaults Ian Rogers
2024-06-25 17:26 ` [PATCH v1 26/26] perf session: Constify tool Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240625172603.900667-5-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=anshuman.khandual@arm.com \
--cc=chenhuacai@kernel.org \
--cc=ilkka@os.amperecomputing.com \
--cc=james.clark@arm.com \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=jonathan.cameron@huawei.com \
--cc=kan.liang@linux.intel.com \
--cc=leo.yan@linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=ndesaulniers@google.com \
--cc=oliver.upton@linux.dev \
--cc=peterz@infradead.org \
--cc=siyanteng@loongson.cn \
--cc=song@kernel.org \
--cc=sunhaiyong@loongson.cn \
--cc=suzuki.poulose@arm.com \
--cc=terrelln@fb.com \
--cc=will@kernel.org \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox