From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Teddy Engel <engel.teddy@gmail.com>
Cc: oe-kbuild-all@lists.linux.dev, devel@driverdev.osuosl.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: rtl8192e: Fix conflicting types error with net_device.
Date: Tue, 25 Jun 2024 17:23:19 +0200 [thread overview]
Message-ID: <2024062553-postbox-gangly-e155@gregkh> (raw)
In-Reply-To: <20240625151918.10839-1-engel.teddy@gmail.com>
On Tue, Jun 25, 2024 at 04:19:18PM +0100, Teddy Engel wrote:
> Add a pre-declaration of struct net_device so the compiler is able to
> use rtl_pci.h / rtl_cam.h.
>
> Fix for commit: 7dff0b27d9c842f88149bf611cbc0b59be1dcd3c:
> [34/59] staging: rtl89192e: Remove unnecessary pre-declaration of struct
> net_device.
>
> Signed-off-by: Teddy Engel <engel.teddy@gmail.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202406250858.L8rJMHQm-lkp@intel.com/
> ---
> v2: Add commit id that's being fixed.
You do that with a "Fixes:" tag, not the paragraph you wrote above :)
The documentation should explain how to do it, right?
thanks,
greg k-h
prev parent reply other threads:[~2024-06-25 15:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 15:19 [PATCH v2] staging: rtl8192e: Fix conflicting types error with net_device Teddy Engel
2024-06-25 15:23 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024062553-postbox-gangly-e155@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=engel.teddy@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox