Re: [PATCH net-next 1/5] netdevice: convert private flags > BIT(31) to bitfields

Jakub Kicinski
2024-06-29T01:59:49Z

On Fri, 28 Jun 2024 17:03:10 +0100 Edward Cree wrote:
> >> It generates sizeof(bitfield) which the compilers don't like and don't
> >> want to compile ._.
> >
> > Mm. Okay, I have no better ideas then.
> >
> > Do consider moving the cold flags next to wol_enabled, tho?
>
> My RSS series moves wol_enabled out to struct ethtool_netdev_state [1] so
> this may not be worthwhile?

Speaking of which a new bit just appeared there, for the SFP module
flashing. I'm gonna merge your series because it technically doesn't
impact it, but could you follow up and move that bit to ethtool state?