Re: [PATCH 1/1] leds: core: Omit set_brightness error message for a LED supporting hw trigger only

Lee Jones
2024-06-26T15:56:19Z

On Mon, 24 Jun 2024, Heiner Kallweit wrote:

> On 20.06.2024 11:09, Lee Jones wrote:
> > On Thu, 13 Jun 2024, Lee Jones wrote:
> >
> >> If both set_brightness functions return -ENOTSUPP, then the LED doesn't
> >> support setting a fixed brightness value, and the error message isn't
> >> helpful. This can be the case e.g. for LEDs supporting a specific hw
> >> trigger only.
> >>
> >> Pinched the subject line and commit message from Heiner:
> >> Link: https://lore.kernel.org/all/44177e37-9512-4044-8991-bb23b184bf37@gmail.com/
> >>
> >> Reworked the function to provide Heiner's required semantics whilst
> >> simultaneously increasing readability and flow.
> >>
> >> Cc: Pavel Machek <pavel@ucw.cz>
> >> Cc: linux-leds@vger.kernel.org
> >> Suggested-by: Heiner Kallweit <hkallweit1@gmail.com>
> >
> > Heiner, you good with this solution?
> >
> > A Tested-by or Reviewed-by would be good if you have the time.
> >
> >> Signed-off-by: Lee Jones <lee@kernel.org>
>
> Reviewed-by: Heiner Kallweit <hkallweit1@gmail.com>

Added, thank you.

--
Lee Jones [李琼斯]