From: Christoph Hellwig <hch@lst.de>
To: Stuart Hayes <stuart.w.hayes@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Martin Belanger <Martin.Belanger@dell.com>,
Oliver O'Halloran <oohall@gmail.com>,
Daniel Wagner <dwagner@suse.de>, Keith Busch <kbusch@kernel.org>,
Lukas Wunner <lukas@wunner.de>,
David Jeffery <djeffery@redhat.com>,
Jeremy Allison <jallison@ciq.com>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH v7 1/4] driver core: don't always lock parent in shutdown
Date: Thu, 27 Jun 2024 07:51:21 +0200 [thread overview]
Message-ID: <20240627055121.GA15415@lst.de> (raw)
In-Reply-To: <20240626194650.3837-2-stuart.w.hayes@gmail.com>
On Wed, Jun 26, 2024 at 02:46:47PM -0500, Stuart Hayes wrote:
> Don't lock a parent device unless it is needed in device_shutdown. This
> is in preparation for making device shutdown asynchronous, when it will
> be needed to allow children of a common parent to shut down
> simultaneously.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
.. but I guess this means async shutdown won't work well for busses
that set this flag (just usb currently)?
next prev parent reply other threads:[~2024-06-27 5:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-26 19:46 [PATCH v7 0/4] shut down devices asynchronously Stuart Hayes
2024-06-26 19:46 ` [PATCH v7 1/4] driver core: don't always lock parent in shutdown Stuart Hayes
2024-06-27 5:51 ` Christoph Hellwig [this message]
2024-06-27 7:30 ` Greg Kroah-Hartman
2024-06-26 19:46 ` [PATCH v7 2/4] driver core: separate function to shutdown one device Stuart Hayes
2024-06-27 5:51 ` Christoph Hellwig
2024-06-26 19:46 ` [PATCH v7 3/4] driver core: shut down devices asynchronously Stuart Hayes
2024-06-27 5:55 ` Christoph Hellwig
2024-07-01 17:57 ` stuart hayes
2024-07-02 5:04 ` Christoph Hellwig
2024-07-02 19:00 ` stuart hayes
2024-06-26 19:46 ` [PATCH v7 4/4] nvme-pci: Make driver prefer asynchronous shutdown Stuart Hayes
2024-06-26 19:58 ` [PATCH v7 0/4] shut down devices asynchronously Keith Busch
2024-06-30 8:49 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240627055121.GA15415@lst.de \
--to=hch@lst.de \
--cc=Martin.Belanger@dell.com \
--cc=axboe@fb.com \
--cc=djeffery@redhat.com \
--cc=dwagner@suse.de \
--cc=gregkh@linuxfoundation.org \
--cc=jallison@ciq.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=lukas@wunner.de \
--cc=oohall@gmail.com \
--cc=rafael@kernel.org \
--cc=sagi@grimberg.me \
--cc=stuart.w.hayes@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox