From: Jason Gunthorpe <jgg@nvidia.com>
To: Yan Zhao <yan.y.zhao@intel.com>
Cc: "Tian, Kevin" <kevin.tian@intel.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"peterx@redhat.com" <peterx@redhat.com>,
"ajones@ventanamicro.com" <ajones@ventanamicro.com>
Subject: Re: [PATCH] vfio: Reuse file f_inode as vfio device inode
Date: Thu, 27 Jun 2024 09:42:09 -0300 [thread overview]
Message-ID: <20240627124209.GK2494510@nvidia.com> (raw)
In-Reply-To: <Zn02BUdJ7kvOg6Vw@yzhao56-desk.sh.intel.com>
On Thu, Jun 27, 2024 at 05:51:01PM +0800, Yan Zhao wrote:
> > > > This doesn't seem right.. There is only one device but multiple file
> > > > can be opened on that device.
> Maybe we can put this assignment to vfio_df_ioctl_bind_iommufd() after
> vfio_df_open() makes sure device->open_count is 1.
Yeah, that seems better.
Logically it would be best if all places set the inode once the
inode/FD has been made to be the one and only way to access it.
> BTW, in group path, what's the benefit of allowing multiple open of device?
I don't know, the thing that opened the first FD can just dup it, no
idea why two different FDs would be useful. It is something we removed
in the cdev flow
Jason
next prev parent reply other threads:[~2024-06-27 12:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-17 9:53 [PATCH] vfio: Reuse file f_inode as vfio device inode Yan Zhao
2024-06-20 10:14 ` Yan Zhao
2024-06-26 8:36 ` Tian, Kevin
2024-06-26 9:11 ` Yan Zhao
2024-06-26 13:35 ` Jason Gunthorpe
2024-06-26 23:55 ` Tian, Kevin
2024-06-27 12:26 ` Jason Gunthorpe
2024-06-27 0:17 ` Tian, Kevin
2024-06-27 9:51 ` Yan Zhao
2024-06-27 12:42 ` Jason Gunthorpe [this message]
2024-06-28 5:21 ` Yan Zhao
2024-06-28 9:48 ` Yi Liu
2024-06-28 15:28 ` Yan Zhao
2024-06-30 7:06 ` Yi Liu
2024-07-01 1:47 ` Yan Zhao
2024-07-01 5:44 ` Yi Liu
2024-07-01 5:48 ` Yan Zhao
2024-07-10 14:40 ` Jason Gunthorpe
2024-07-12 5:19 ` Yan Zhao
2024-07-12 6:14 ` Yi Liu
2024-07-01 7:54 ` Yi Liu
2024-07-01 11:29 ` Yan Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240627124209.GK2494510@nvidia.com \
--to=jgg@nvidia.com \
--cc=ajones@ventanamicro.com \
--cc=alex.williamson@redhat.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterx@redhat.com \
--cc=yan.y.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox